Skip to content

Commit f684642

Browse files
committed
mingw: use domain information for default email
When a user is registered in a Windows domain, it is really easy to obtain the email address. So let's do that. Suggested by Lutz Roeder. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent b1885a7 commit f684642

File tree

4 files changed

+14
-1
lines changed

4 files changed

+14
-1
lines changed

compat/mingw.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1871,6 +1871,11 @@ static char *get_extended_user_info(enum EXTENDED_NAME_FORMAT type)
18711871
return NULL;
18721872
}
18731873

1874+
char *mingw_query_user_email(void)
1875+
{
1876+
return get_extended_user_info(NameUserPrincipal);
1877+
}
1878+
18741879
struct passwd *getpwuid(int uid)
18751880
{
18761881
static unsigned initialized;

compat/mingw.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -429,6 +429,8 @@ int mingw_offset_1st_component(const char *path);
429429
#define PATH_SEP ';'
430430
extern const char *program_data_config(void);
431431
#define git_program_data_config program_data_config
432+
extern char *mingw_query_user_email(void);
433+
#define query_user_email mingw_query_user_email
432434
#if !defined(__MINGW64_VERSION_MAJOR) && (!defined(_MSC_VER) || _MSC_VER < 1800)
433435
#define PRIuMAX "I64u"
434436
#define PRId64 "I64d"

git-compat-util.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,10 @@ static inline char *git_find_last_dir_sep(const char *path)
376376
#define git_program_data_config() NULL
377377
#endif
378378

379+
#ifndef query_user_email
380+
#define query_user_email() NULL
381+
#endif
382+
379383
#if defined(__HP_cc) && (__HP_cc >= 61000)
380384
#define NORETURN __attribute__((noreturn))
381385
#define NORETURN_PTR

ident.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,9 @@ const char *ident_default_email(void)
169169
strbuf_addstr(&git_default_email, email);
170170
committer_ident_explicitly_given |= IDENT_MAIL_GIVEN;
171171
author_ident_explicitly_given |= IDENT_MAIL_GIVEN;
172-
} else
172+
} else if ((email = query_user_email()) && email[0])
173+
strbuf_addstr(&git_default_email, email);
174+
else
173175
copy_email(xgetpwuid_self(&default_email_is_bogus),
174176
&git_default_email, &default_email_is_bogus);
175177
strbuf_trim(&git_default_email);

0 commit comments

Comments
 (0)