Skip to content

Commit ff75e6c

Browse files
committed
Merge branch 'os/vcbuild'
Fix build procedure for MSVC. * os/vcbuild: contrib/buildsystems: fix expat library name for generated vcxproj vcbuild: fix batch file name in README vcbuild: fix library name for expat with make MSVC=1
2 parents 0df670b + e58e405 commit ff75e6c

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

compat/vcbuild/README

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ The Steps to Build Git with VS2015 or VS2017 from the command line.
2626
Use ONE of the following forms which should match how you want to
2727
compile git.exe.
2828

29-
$ ./compat/vcbuild/vcpkg_copy_packages.bat debug
30-
$ ./compat/vcbuild/vcpkg_copy_packages.bat release
29+
$ ./compat/vcbuild/vcpkg_copy_dlls.bat debug
30+
$ ./compat/vcbuild/vcpkg_copy_dlls.bat release
3131

3232
3. Build git using MSVC from an SDK bash window using one of the
3333
following commands:

compat/vcbuild/scripts/clink.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
}
6767
push(@args, $lib);
6868
} elsif ("$arg" eq "-lexpat") {
69-
push(@args, "expat.lib");
69+
push(@args, "libexpat.lib");
7070
} elsif ("$arg" =~ /^-L/ && "$arg" ne "-LTCG") {
7171
$arg =~ s/^-L/-LIBPATH:/;
7272
push(@lflags, $arg);

contrib/buildsystems/Generators/Vcxproj.pm

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ sub createProject {
8080
$libs_release = join(";", sort(grep /^(?!libgit\.lib|xdiff\/lib\.lib|vcs-svn\/lib\.lib)/, @{$$build_structure{"$prefix${name}_LIBS"}}));
8181
$libs_debug = $libs_release;
8282
$libs_debug =~ s/zlib\.lib/zlibd\.lib/g;
83+
$libs_debug =~ s/libexpat\.lib/libexpatd\.lib/g;
8384
$libs_debug =~ s/libcurl\.lib/libcurl-d\.lib/g;
8485
}
8586

contrib/buildsystems/engine.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ sub handleLinkLine
349349
} elsif ("$part" eq "-lcurl") {
350350
push(@libs, "libcurl.lib");
351351
} elsif ("$part" eq "-lexpat") {
352-
push(@libs, "expat.lib");
352+
push(@libs, "libexpat.lib");
353353
} elsif ("$part" eq "-liconv") {
354354
push(@libs, "libiconv.lib");
355355
} elsif ($part =~ /^[-\/]/) {

0 commit comments

Comments
 (0)