CONTRIBUTING.md: check for whitespace before submitting #1567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whitespace errors are easy to create but hard to check manually. Add two git commands that detect these whitespace errors to the commit cleanup section of CONTRIBUTING.md. Signed-off-by: Derrick Stolee <[email protected]>
|
Perfect, thanks, both! |
|
I tend to notice via the Git Gui, which I usually use to review changes and my commit message. The GIt Gui also has white-space checking available. - Maybe worth noting. |
|
Welcome back @PhilipOakley! Yes, that's a good point. Would you mind opening a PR to add this tip? |
dscho
added a commit
that referenced
this pull request
Mar 23, 2018
CONTRIBUTING.md: check for whitespace before submitting
dscho
added a commit
that referenced
this pull request
Apr 3, 2018
CONTRIBUTING.md: check for whitespace before submitting
dscho
added a commit
that referenced
this pull request
May 29, 2018
CONTRIBUTING.md: check for whitespace before submitting
dscho
added a commit
that referenced
this pull request
May 29, 2018
CONTRIBUTING.md: check for whitespace before submitting
dscho
added a commit
that referenced
this pull request
May 29, 2018
CONTRIBUTING.md: check for whitespace before submitting
dscho
added a commit
that referenced
this pull request
May 29, 2018
CONTRIBUTING.md: check for whitespace before submitting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitespace errors are easy to create but hard to check manually. Add
two git commands that detect these whitespace errors to the commit
cleanup section of CONTRIBUTING.md.