vcxproj: change build logic #1679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new condition to invoke vcpkg_install.bat: it's not enough to check the presence of folder vcpkg. We need to check the presence of some header files because this is one of the main goals of this script. Previous build attempt could be aborted, so the folder will exist but the project will not be built properly. Signed-off-by: Olga Telezhnaia <[email protected]>
|
Very nice! Thanks |
PKRoma
pushed a commit
to PKRoma/git-for-windows
that referenced
this pull request
Jun 22, 2018
vcxproj: change build logic
PKRoma
pushed a commit
to PKRoma/git-for-windows
that referenced
this pull request
Jun 22, 2018
vcxproj: change build logic
PKRoma
pushed a commit
to PKRoma/git-for-windows
that referenced
this pull request
Jun 22, 2018
vcxproj: change build logic
dscho
added a commit
to dscho/git
that referenced
this pull request
Aug 22, 2018
vcxproj: change build logic
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Aug 28, 2018
vcxproj: change build logic
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Sep 5, 2018
vcxproj: change build logic
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 10, 2018
vcxproj: change build logic
jamill
pushed a commit
to jamill/git
that referenced
this pull request
Sep 11, 2018
vcxproj: change build logic
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 24, 2018
vcxproj: change build logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new condition to invoke vcpkg_install.bat: it's not enough to check
the presence of folder vcpkg. We need to check the presence of some
header files because this is one of the main goals of this script.
Previous build attempt could be aborted, so the folder will exist but
the project will not be built properly.
Signed-off-by: Olga Telezhnaia [email protected]