Prepare the gc tests for v3.x of the MSYS2 runtime #2180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Git for Windows, we use the MSYS2 Bash which inherits a non-standard PID model from Cygwin's POSIX emulation layer: every MSYS2 process has a regular Windows PID, and in addition it has an MSYS2 PID (which corresponds to a shadow process that emulates Unix-style signal handling). With the upgrade to the MSYS2 runtime v3.x, this shadow process cannot be accessed via `OpenProcess()` any longer, and therefore t6500 thought incorrectly that the process referenced in `gc.pid` (which is not actually a real `gc` process in this context, but the current shell) no longer exists. Let's fix this by making sure that the Windows PID is written into `gc.pid` in this test script soo that `git.exe` is able to understand that that process does indeed still exist. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
added a commit
that referenced
this pull request
May 7, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
May 7, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 8, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
May 8, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
May 9, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
May 9, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
May 9, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 9, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
May 10, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
May 10, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
May 10, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 10, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 10, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 10, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
May 13, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
May 13, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
to dscho/git
that referenced
this pull request
May 13, 2019
…ntime-v3.x Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
to dscho/git
that referenced
this pull request
May 13, 2019
…ntime-v3.x Prepare the gc tests for v3.x of the MSYS2 runtime
git-for-windows-ci
pushed a commit
that referenced
this pull request
May 14, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
May 14, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
May 21, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
May 22, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
May 25, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
Jun 4, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
dscho
added a commit
that referenced
this pull request
Jun 8, 2019
Prepare the gc tests for v3.x of the MSYS2 runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was always a tricky thing to run Git's scripts with MSYS2 while insisting on running the rest via the non-MSYS2
git.exe.With v3.x of the MSYS2 runtime, this became even trickier, as it now seems that the Cygwin/MSYS2 process IDs no longer are actual Windows process IDs anymore. Or at least
git.execannot open those processes (andwmic process listseems not to list them, either).This PR fixes the (as far as I can tell) only test case that relied on this previously.