FSMonitor v2: fix another fall-out of since_token being potentially NULL
#3258
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another instance where `since_token` was expected to be non-`NULL`, but apparently it is quite possible, as demonstrated by Scalar's Functional Test suite. Signed-off-by: Johannes Schindelin <[email protected]>
derrickstolee
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have looked much more closely when crafting #3241: there was one other instance where
since_tokenwas not expected to beNULL: the Trace2 call. This only showed up in Scalar's Functional Tests because it created the situation where a new Git index is initialized (obviously, without a valid FSMonitor token) and all of the Trace2 knobs are turned on.