Skip to content

Two monitor-components fixes #4168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

dscho
Copy link
Member

@dscho dscho commented Dec 15, 2022

The monitor-components workflow's purpose is to notify the Git for Windows maintainers when new package versions are published and may need to be integrated into Git for Windows.

This PR brings two improvements to this workflow:

monitor-components: only run this in Git for Windows' fork

Even if scheduled workflows are supposedly disabled in forks, we see it
every once in a while that they are turned on by mistake.

However, the `monitor-components` workflow really only makes sense in
Git for Windows' fork, as its purpose is to notify the Git for Windows
maintainers of new package versions that might need to be integrated
into Git for Windows.

So let's be more explicit about disabling this workflow everywhere else.

Signed-off-by: Johannes Schindelin <[email protected]>
component-updates: fix label and URL for Git Credential Manager

The repository moved a long time, so let's adjust the URL.

Also adjust the label because the new automation orchestrated via
https://github.com/dscho/gfw-helper-github-app/ and
https://github.com/git-for-windows/git-for-windows-automation/ relies on
the label matching the package name.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho self-assigned this Dec 15, 2022
@rimrul
Copy link
Member

rimrul commented Dec 15, 2022

Reworded the PR description so GitHub doesn't close any issues when we merge this PR.

@dscho dscho merged commit 1396a3d into git-for-windows:main Dec 16, 2022
@dscho dscho deleted the fix-gcm-label-in-monitor-components branch December 16, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants