Use node-fetch for fetchJSONFromURL

Author: dennisameling

__tests__/downloader.test.ts

@@ -1,7 +1,6 @@
-import {ClientRequest, IncomingMessage} from 'http'
-import https from 'https'
-import {mocked} from 'ts-jest/utils'
 import {get} from '../src/downloader'
+import {mocked} from 'ts-jest/utils'
+import fetch from 'node-fetch'
 
 const buildIdResponse = {
   count: 1,
@@ -43,38 +42,14 @@ const buildIdResponse = {
   ]
 }
 
-jest.mock('https')
-
-declare type Callback = (data?: object) => void
+jest.mock('node-fetch')
+const {Response} = jest.requireActual('node-fetch')
 
 test('can obtain build ID', async () => {
-  mocked(https.request).mockImplementation(
-    (
-      _url,
-      _options,
-      callback: ((res: IncomingMessage) => void) | undefined
-    ): ClientRequest => {
-      const res = {
-        statusCode: 200,
-        on: (eventType: string, eventCallback: Callback): object => {
-          switch (eventType) {
-            case 'data':
-              eventCallback(Buffer.from(JSON.stringify(buildIdResponse)))
-              break
-            case 'end':
-              eventCallback()
-              break
-          }
-          return res
-        }
-      } as IncomingMessage
-      expect(callback).not.toBeUndefined()
-      callback && callback(res)
-      const req = {} as ClientRequest
-      Object.assign(req, {on: () => {}})
-      return req
-    }
+  mocked(fetch).mockReturnValue(
+    Promise.resolve(new Response(JSON.stringify(buildIdResponse)))
   )
   const {id} = await get('minimal', 'x86_64')
+  expect(fetch).toHaveBeenCalledTimes(1)
   expect(id).toEqual('git-sdk-64-minimal-71000')
 })

package.json

@@ -29,6 +29,7 @@
   "dependencies": {
     "@actions/cache": "^1.0.6",
     "@actions/core": "^1.2.6",
+    "node-fetch": "^2.6.1",
     "unzipper": "^0.10.11"
   },
   "devDependencies": {

src/downloader.ts

@@ -4,36 +4,28 @@ import {Readable} from 'stream'
 import unzipper from 'unzipper'
 import {spawn} from 'child_process'
 import {delimiter} from 'path'
+import fetch from 'node-fetch'
 
 const gitForWindowsUsrBinPath = 'C:/Program Files/Git/usr/bin'
 const gitForWindowsMINGW64BinPath = 'C:/Program Files/Git/mingw64/bin'
 
 async function fetchJSONFromURL<T>(url: string): Promise<T> {
-  return new Promise<T>((resolve, reject) => {
-    https
-      .request(url, {}, res => {
-        if (res.statusCode !== 200) {
-          reject(
-            new Error(
-              `Got code ${res.statusCode}, URL: ${url}, message: ${res.statusMessage}`
-            )
+  return new Promise<T>(async (resolve, reject) => {
+    try {
+      const res = await fetch(url)
+      if (res.status !== 200) {
+        reject(
+          new Error(
+            `Got code ${res.status}, URL: ${url}, message: ${res.statusText}`
           )
-          return
-        }
-        const data: Uint8Array[] = []
-        res
-          .on('data', (chunk: Uint8Array) => data.push(chunk))
-          .on('end', () => {
-            try {
-              resolve(JSON.parse(Buffer.concat(data).toString('utf-8')))
-            } catch (e) {
-              reject(e)
-            }
-          })
-          .on('error', e => reject(e))
-      })
-      .on('error', e => reject(e))
-      .end()
+        )
+        return
+      }
+
+      resolve(res.json())
+    } catch (e) {
+      reject(e)
+    }
   })
 }