chore(ci): Ban for_each

epage · epage · commit 60a8ec89e3f9 · 2023-04-17T20:03:56.000-05:00
diff --git a/.clippy.toml b/.clippy.toml
@@ -9,4 +9,6 @@ disallowed-methods = [
     { path = "std::option::Option::map_or_else", reason = "use `map(..).unwrap_or_else(..)`" },
     { path = "std::result::Result::map_or", reason = "use `map(..).unwrap_or(..)`" },
     { path = "std::result::Result::map_or_else", reason = "use `map(..).unwrap_or_else(..)`" },
+    { path = "std::iter::Iterator::for_each", reason = "prefer `for` for side-effects" },
+    { path = "std::iter::Iterator::try_for_each", reason = "prefer `for` for side-effects" },
 ]

Original file line number	Diff line number	Diff line change
`@@ -9,4 +9,6 @@ disallowed-methods = [`
`9`	`9`	{ path = "std::option::Option::map_or_else", reason = "use `map(..).unwrap_or_else(..)`" },
`10`	`10`	{ path = "std::result::Result::map_or", reason = "use `map(..).unwrap_or(..)`" },
`11`	`11`	{ path = "std::result::Result::map_or_else", reason = "use `map(..).unwrap_or_else(..)`" },
	`12`	+ { path = "std::iter::Iterator::for_each", reason = "prefer `for` for side-effects" },
	`13`	+ { path = "std::iter::Iterator::try_for_each", reason = "prefer `for` for side-effects" },
`12`	`14`	`]`