Skip to content

Commit 0370b35

Browse files
bk2204gitster
authored andcommitted
t4038: abstract away SHA-1 specific constants
Compute several object IDs that exist in expected output, since we don't care about the specific object IDs, only that the format of the output is syntactically correct. Signed-off-by: brian m. carlson <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 0253e12 commit 0370b35

File tree

1 file changed

+13
-6
lines changed

1 file changed

+13
-6
lines changed

t/t4038-diff-combined.sh

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -440,25 +440,28 @@ test_expect_success 'setup for --combined-all-paths' '
440440
git branch side2c &&
441441
git checkout side1c &&
442442
test_seq 1 10 >filename-side1c &&
443+
side1cf=$(git hash-object filename-side1c) &&
443444
git add filename-side1c &&
444445
git commit -m with &&
445446
git checkout side2c &&
446447
test_seq 1 9 >filename-side2c &&
447448
echo ten >>filename-side2c &&
449+
side2cf=$(git hash-object filename-side2c) &&
448450
git add filename-side2c &&
449451
git commit -m iam &&
450452
git checkout -b mergery side1c &&
451453
git merge --no-commit side2c &&
452454
git rm filename-side1c &&
453455
echo eleven >>filename-side2c &&
454456
git mv filename-side2c filename-merged &&
457+
mergedf=$(git hash-object filename-merged) &&
455458
git add filename-merged &&
456459
git commit
457460
'
458461

459462
test_expect_success '--combined-all-paths and --raw' '
460-
cat <<-\EOF >expect &&
461-
::100644 100644 100644 f00c965d8307308469e537302baa73048488f162 088bd5d92c2a8e0203ca8e7e4c2a5c692f6ae3f7 333b9c62519f285e1854830ade0fe1ef1d40ee1b RR filename-side1c filename-side2c filename-merged
463+
cat <<-EOF >expect &&
464+
::100644 100644 100644 $side1cf $side2cf $mergedf RR filename-side1c filename-side2c filename-merged
462465
EOF
463466
git diff-tree -c -M --raw --combined-all-paths HEAD >actual.tmp &&
464467
sed 1d <actual.tmp >actual &&
@@ -482,32 +485,36 @@ test_expect_success FUNNYNAMES 'setup for --combined-all-paths with funny names'
482485
git checkout side1d &&
483486
test_seq 1 10 >"$(printf "file\twith\ttabs")" &&
484487
git add file* &&
488+
side1df=$(git hash-object *tabs) &&
485489
git commit -m with &&
486490
git checkout side2d &&
487491
test_seq 1 9 >"$(printf "i\tam\ttabbed")" &&
488492
echo ten >>"$(printf "i\tam\ttabbed")" &&
489493
git add *tabbed &&
494+
side2df=$(git hash-object *tabbed) &&
490495
git commit -m iam &&
491496
git checkout -b funny-names-mergery side1d &&
492497
git merge --no-commit side2d &&
493498
git rm *tabs &&
494499
echo eleven >>"$(printf "i\tam\ttabbed")" &&
495500
git mv "$(printf "i\tam\ttabbed")" "$(printf "fickle\tnaming")" &&
496501
git add fickle* &&
497-
git commit
502+
headf=$(git hash-object fickle*) &&
503+
git commit &&
504+
head=$(git rev-parse HEAD)
498505
'
499506

500507
test_expect_success FUNNYNAMES '--combined-all-paths and --raw and funny names' '
501-
cat <<-\EOF >expect &&
502-
::100644 100644 100644 f00c965d8307308469e537302baa73048488f162 088bd5d92c2a8e0203ca8e7e4c2a5c692f6ae3f7 333b9c62519f285e1854830ade0fe1ef1d40ee1b RR "file\twith\ttabs" "i\tam\ttabbed" "fickle\tnaming"
508+
cat <<-EOF >expect &&
509+
::100644 100644 100644 $side1df $side2df $headf RR "file\twith\ttabs" "i\tam\ttabbed" "fickle\tnaming"
503510
EOF
504511
git diff-tree -c -M --raw --combined-all-paths HEAD >actual.tmp &&
505512
sed 1d <actual.tmp >actual &&
506513
test_cmp expect actual
507514
'
508515

509516
test_expect_success FUNNYNAMES '--combined-all-paths and --raw -and -z and funny names' '
510-
printf "aaf8087c3cbd4db8e185a2d074cf27c53cfb75d7\0::100644 100644 100644 f00c965d8307308469e537302baa73048488f162 088bd5d92c2a8e0203ca8e7e4c2a5c692f6ae3f7 333b9c62519f285e1854830ade0fe1ef1d40ee1b RR\0file\twith\ttabs\0i\tam\ttabbed\0fickle\tnaming\0" >expect &&
517+
printf "$head\0::100644 100644 100644 $side1df $side2df $headf RR\0file\twith\ttabs\0i\tam\ttabbed\0fickle\tnaming\0" >expect &&
511518
git diff-tree -c -M --raw --combined-all-paths -z HEAD >actual &&
512519
test_cmp -a expect actual
513520
'

0 commit comments

Comments
 (0)