Skip to content

Commit 26be15f

Browse files
dschogitster
authored andcommitted
filter-branch: do not consider diverging submodules a 'dirty worktree'
At the end of filter-branch in a non-bare repository, the work tree is updated with "read-tree -m -u HEAD", to carry the change forward in case the current branch was rewritten. In order to avoid losing any local change during this step, filter-branch refuses to work when there are local changes in the work tree. This "read-tree -m -u HEAD" operation does not affect what commit is checked out in a submodule (iow, it does not touch .git/HEAD in a submodule checkout), and checking if there is any local change to the submodule is not useful. Staged submodules _are_ considered to be 'dirty', however, as the "read-tree -m -u HEAD" could result in loss of staged information otherwise. Signed-off-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 9273b56 commit 26be15f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

git-filter-branch.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ OPTIONS_SPEC=
9898
. git-sh-setup
9999

100100
if [ "$(is_bare_repository)" = false ]; then
101-
git diff-files --quiet &&
101+
git diff-files --ignore-submodules --quiet &&
102102
git diff-index --cached --quiet HEAD -- ||
103103
die "Cannot rewrite branch(es) with a dirty working directory."
104104
fi

0 commit comments

Comments
 (0)