Skip to content

Commit 41ebd16

Browse files
committed
Meta/CannedResponses: do not iterate too quickly
1 parent e529196 commit 41ebd16

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

CannedResponses

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ The usual way to compose a log message of this project is to
1212
- Propose a solution (optional---often, problem description
1313
trivially leads to an obvious solution in reader's minds).
1414

15-
- Give commands to the codebase to "become like so".
15+
- Give commands to somebody editing the codebase to "make it so".
1616

1717
in this order.
1818

@@ -107,3 +107,19 @@ entirely and replacing it with the newer one. In such a case, we do
107107
revert the earlier and replace it with the newer, in 'next'.
108108

109109
----------------------------------------------------------------
110+
[do not iterate too quickly]
111+
112+
After sending your patches out, it would be nice to give potential
113+
reviewers at least 24 hours to ensure people anywhere on the globe
114+
have a chance to comment, and a chance for you to respond to them,
115+
before sending your next iteration.
116+
117+
When responding to a review comment that causes you to drastically
118+
change the course of the series, it is nice to give potential
119+
reviewers at least 24 hours to ensure they have a chance to voice
120+
their opinions, before sending an updated series based on that
121+
comment, because suggested changes in such a comment may be
122+
controversial and deserve discussion. After seeing you spend some
123+
time already to adjust to one opinion on such a discussion, others may
124+
feel discouraged to make you redo your series again even whey they
125+
think the suggested changes are not taking us in the right direction.

0 commit comments

Comments
 (0)