Skip to content

Commit 63ee933

Browse files
pks-tgitster
pks-t
authored and
gitster
committed
t98xx: mark Perforce tests as memory-leak free
All the Perforce tests are free of memory leaks. This went unnoticed because most folks do not have p4 and p4d installed on their computers. Consequently, given that the prerequisites for running those tests aren't fulfilled, `TEST_PASSES_SANITIZE_LEAK=check` won't notice that those tests are indeed memory leak free. Mark those tests accordingly. Signed-off-by: Patrick Steinhardt <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent d707d23 commit 63ee933

35 files changed

+35
-0
lines changed

‎t/t9800-git-p4-basic.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ test_description='git p4 tests'
55
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
66
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
77

8+
TEST_PASSES_SANITIZE_LEAK=true
89
. ./lib-git-p4.sh
910

1011
test_expect_success 'start p4d' '

‎t/t9801-git-p4-branch.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ test_description='git p4 tests for p4 branches'
55
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
66
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
77

8+
TEST_PASSES_SANITIZE_LEAK=true
89
. ./lib-git-p4.sh
910

1011
test_expect_success 'start p4d' '

‎t/t9802-git-p4-filetype.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 filetype tests'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9803-git-p4-shell-metachars.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 transparency to shell metachars in filenames'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9804-git-p4-label.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 label tests'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9805-git-p4-skip-submit-edit.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 skipSubmitEdit config variables'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9806-git-p4-options.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ test_description='git p4 options'
55
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
66
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
77

8+
TEST_PASSES_SANITIZE_LEAK=true
89
. ./lib-git-p4.sh
910

1011
test_expect_success 'start p4d' '

‎t/t9808-git-p4-chdir.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 relative chdir'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9809-git-p4-client-view.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 client view'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9810-git-p4-rcs.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 rcs keywords'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
CP1252="\223\224"

‎t/t9811-git-p4-label-import.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ test_description='git p4 label tests'
55
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
66
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
77

8+
TEST_PASSES_SANITIZE_LEAK=true
89
. ./lib-git-p4.sh
910

1011
test_expect_success 'start p4d' '

‎t/t9812-git-p4-wildcards.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 wildcards'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9813-git-p4-preserve-users.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 preserve users'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9814-git-p4-rename.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 rename'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9815-git-p4-submit-fail.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 submit failure handling'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9816-git-p4-locked.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 locked file behavior'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9817-git-p4-exclude.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 tests for excluded paths during clone and sync'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9818-git-p4-block.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 fetching changes in multiple blocks'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9819-git-p4-case-folding.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='interaction with P4 case-folding'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
if test_have_prereq CASE_INSENSITIVE_FS

‎t/t9820-git-p4-editor-handling.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 handling of EDITOR'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9821-git-p4-path-variations.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='Clone repositories with path case variations'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d with case folding enabled' '

‎t/t9822-git-p4-path-encoding.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='Clone repositories with non ASCII paths'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
UTF8_ESCAPED="a-\303\244_o-\303\266_u-\303\274.txt"

‎t/t9823-git-p4-mock-lfs.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='Clone repositories and store files in Mock LFS'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_file_is_not_in_mock_lfs () {

‎t/t9825-git-p4-handle-utf16-without-bom.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 handling of UTF-16 files without BOM'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
UTF16="\227\000\227\000"

‎t/t9826-git-p4-keep-empty-commits.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='Clone repositories and keep empty commits'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9827-git-p4-change-filetype.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 support for file type change'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9828-git-p4-map-user.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='Clone repositories and map users'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9829-git-p4-jobs.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 retrieve job info'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9830-git-p4-symlink-dir.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 symlinked directories'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9831-git-p4-triggers.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 with server triggers'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9832-unshelve.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ last_shelved_change () {
66

77
test_description='git p4 unshelve'
88

9+
TEST_PASSES_SANITIZE_LEAK=true
910
. ./lib-git-p4.sh
1011

1112
test_expect_success 'start p4d' '

‎t/t9833-errors.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='git p4 errors'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./lib-git-p4.sh
67

78
test_expect_success 'start p4d' '

‎t/t9834-git-p4-file-dir-bug.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ This test creates files and directories with the same name in perforce and
66
checks that git-p4 recovers from the error at the same time as the perforce
77
repository.'
88

9+
TEST_PASSES_SANITIZE_LEAK=true
910
. ./lib-git-p4.sh
1011

1112
test_expect_success 'start p4d' '

‎t/t9835-git-p4-metadata-encoding-python2.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ This test checks that the import process handles inconsistent text
66
encoding in p4 metadata (author names, commit messages, etc) without
77
failing, and produces maximally sane output in git.'
88

9+
TEST_PASSES_SANITIZE_LEAK=true
910
. ./lib-git-p4.sh
1011

1112
python_target_version='2'

‎t/t9836-git-p4-metadata-encoding-python3.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ This test checks that the import process handles inconsistent text
66
encoding in p4 metadata (author names, commit messages, etc) without
77
failing, and produces maximally sane output in git.'
88

9+
TEST_PASSES_SANITIZE_LEAK=true
910
. ./lib-git-p4.sh
1011

1112
python_target_version='3'

0 commit comments

Comments
 (0)