Skip to content

Commit 7f0b590

Browse files
peffgitster
authored andcommitted
t0000: reword comments for "local" test
Commit 01d3a52 (t0000: check whether the shell supports the "local" keyword, 2017-10-26) added a test to gather data on whether people run the test suite with shells that don't support "local". After almost two years, nobody has complained, and several other uses have cropped up in test-lib-functions.sh. Let's declare it acceptable to use. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 1c1f6e0 commit 7f0b590

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

t/t0000-basic.sh

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,14 @@ try_local_x () {
2525
echo "$x"
2626
}
2727

28-
# This test is an experiment to check whether any Git users are using
29-
# Shells that don't support the "local" keyword. "local" is not
28+
# Check whether the shell supports the "local" keyword. "local" is not
3029
# POSIX-standard, but it is very widely supported by POSIX-compliant
31-
# shells, and if it doesn't cause problems for people, we would like
32-
# to be able to use it in Git code.
30+
# shells, and we rely on it within Git's test framework.
3331
#
34-
# For now, this is the only test that requires "local". If your shell
35-
# fails this test, you can ignore the failure, but please report the
36-
# problem to the Git mailing list <[email protected]>, as it might
37-
# convince us to continue avoiding the use of "local".
32+
# If your shell fails this test, the results of other tests may be
33+
# unreliable. You may wish to report the problem to the Git mailing
34+
# list <[email protected]>, as it could cause us to reconsider
35+
# relying on "local".
3836
test_expect_success 'verify that the running shell supports "local"' '
3937
x="notlocal" &&
4038
echo "local" >expected1 &&

0 commit comments

Comments
 (0)