Skip to content

Commit d0fb541

Browse files
committed
rebase: help users when dying with preserve-merges
Git will die if a "rebase --preserve-merges" is in progress. Users cannot --quit, --abort or --continue the rebase. Make the `rebase --abort` option available to allow users to remove traces of any preserve-merges rebase, even if they had upgraded during a rebase. One trigger was an unexpectedly difficult to resolve conflict, as reported on the `git-users` group. (https://groups.google.com/g/git-for-windows/c/3jMWbBlXXHM) Tell the user the options to resolve the problem manually. Signed-off-by: Philip Oakley <[email protected]>
1 parent 0a4c81d commit d0fb541

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

builtin/rebase.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1182,8 +1182,10 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
11821182
} else if (is_directory(merge_dir())) {
11831183
strbuf_reset(&buf);
11841184
strbuf_addf(&buf, "%s/rewritten", merge_dir());
1185-
if (is_directory(buf.buf)) {
1186-
die("`rebase -p` is no longer supported");
1185+
if (is_directory(buf.buf) && !(action == ACTION_ABORT)) {
1186+
die("`rebase --preserve-merges` (-p) is no longer supported.\n"
1187+
"Use `git rebase --abort` to terminate current rebase.\n"
1188+
"Or downgrade to v2.33, or earlier, to complete the rebase.\n");
11871189
} else {
11881190
strbuf_reset(&buf);
11891191
strbuf_addf(&buf, "%s/interactive", merge_dir());

0 commit comments

Comments
 (0)