Skip to content

Commit d1018c2

Browse files
bk2204gitster
authored andcommitted
t5601: fix quotation error leading to skipped tests
One of the tests in t5601 used single quotes to delimit an argument containing spaces. However, this caused test_expect_success to be passed three arguments instead of two, which in turn caused the test name to be treated as a prerequisite instead of a test name. As there was no prerequisite called "bracketed hostnames are still ssh", the test was always skipped. Because this test was always skipped, the fact that it passed the arguments in the wrong order was obscured. Use double quotes inside the test and reorder the arguments so that the test runs and properly reflects the arguments that are passed to ssh. Signed-off-by: brian m. carlson <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 37ee646 commit d1018c2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

t/t5601-clone.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ test_expect_success !MINGW,!CYGWIN 'clone local path foo:bar' '
332332

333333
test_expect_success 'bracketed hostnames are still ssh' '
334334
git clone "[myhost:123]:src" ssh-bracket-clone &&
335-
expect_ssh myhost '-p 123' src
335+
expect_ssh "-p 123" myhost src
336336
'
337337

338338
counter=0

0 commit comments

Comments
 (0)