Skip to content

Commit e5e3751

Browse files
avargitster
authored andcommitted
tests: mark tests as passing with SANITIZE=leak
This marks tests that have been leak-free since various recent commits, but which were not marked us such when the memory leak was fixed. These were mostly discovered with the "check" mode added in faececa (test-lib: have the "check" mode for SANITIZE=leak consider leak logs, 2022-07-28). Commits that fixed the last memory leak in these tests. Per narrowing down when they started to pass under SANITIZE=leak with "bisect": - t1022-read-tree-partial-clone.sh: 7e2619d (list_objects_filter_options: plug leak of filter_spec strings, 2022-09-08) - t4053-diff-no-index.sh: 07a6f94 (diff-no-index: release prefixed filenames, 2022-09-07) - t6415-merge-dir-to-symlink.sh: bac92b1 (Merge branch 'js/ort-clean-up-after-failed-merge', 2022-08-08). - t5554-noop-fetch-negotiator.sh: 66eede4 (prepare_repo_settings(): plug leak of config values, 2022-09-08) - t2012-checkout-last.sh, t7504-commit-msg-hook.sh, t91{15,46,60}-git-svn-*.sh: The in-flight "pw/rebase-no-reflog-action" series, upon which this is based: https://lore.kernel.org/git/[email protected]/ Let's mark all of these as passing with "TEST_PASSES_SANITIZE_LEAK=true", to have it regression tested, including as part of the "linux-leaks" CI job. Additionally, let's remove the "!SANITIZE_LEAK" prerequisite from tests that now pass, these were marked as failing in: - 77e56d5 (diff.c: fix a double-free regression in a18d66c, 2022-03-17) - c4d1d52 (tests: change some 'test $(git) = "x"' to test_cmp, 2022-03-07) These were not spotted with the new "check" mode, but manually, it doesn't cover these sort of prerequisites. There's few enough that we shouldn't bother to automate it. They'll be going away sooner than later. Signed-off-by: Ævar Arnfjörð Bjarmason <[email protected]> Signed-off-by: Taylor Blau <[email protected]>
1 parent cb34852 commit e5e3751

11 files changed

+10
-7
lines changed

t/t1022-read-tree-partial-clone.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
test_description='git read-tree in partial clones'
44

55
TEST_NO_CREATE_REPO=1
6-
6+
TEST_PASSES_SANITIZE_LEAK=true
77
. ./test-lib.sh
88

99
test_expect_success 'read-tree in partial clone prefetches in one batch' '

t/t2012-checkout-last.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ test_description='checkout can switch to last branch and merge base'
55
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
66
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
77

8+
TEST_PASSES_SANITIZE_LEAK=true
89
. ./test-lib.sh
910

1011
test_expect_success 'setup' '

t/t4015-diff-whitespace.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1638,7 +1638,7 @@ test_expect_success 'no effect on diff from --color-moved with --word-diff' '
16381638
test_cmp expect actual
16391639
'
16401640

1641-
test_expect_success !SANITIZE_LEAK 'no effect on show from --color-moved with --word-diff' '
1641+
test_expect_success 'no effect on show from --color-moved with --word-diff' '
16421642
git show --color-moved --word-diff >actual &&
16431643
git show --word-diff >expect &&
16441644
test_cmp expect actual
@@ -2024,7 +2024,7 @@ test_expect_success '--color-moved rewinds for MIN_ALNUM_COUNT' '
20242024
test_cmp expected actual
20252025
'
20262026

2027-
test_expect_success !SANITIZE_LEAK 'move detection with submodules' '
2027+
test_expect_success 'move detection with submodules' '
20282028
test_create_repo bananas &&
20292029
echo ripe >bananas/recipe &&
20302030
git -C bananas add recipe &&

t/t4053-diff-no-index.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
test_description='diff --no-index'
44

5+
TEST_PASSES_SANITIZE_LEAK=true
56
. ./test-lib.sh
67

78
test_expect_success 'setup' '

t/t5554-noop-fetch-negotiator.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
#!/bin/sh
22

33
test_description='test noop fetch negotiator'
4+
5+
TEST_PASSES_SANITIZE_LEAK=true
46
. ./test-lib.sh
57

68
test_expect_success 'noop negotiator does not emit any "have"' '

t/t6415-merge-dir-to-symlink.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ test_description='merging when a directory was replaced with a symlink'
44
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
55
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
66

7+
TEST_PASSES_SANITIZE_LEAK=true
78
. ./test-lib.sh
89

910
test_expect_success 'create a commit where dir a/b changed to symlink' '

t/t7103-reset-bare.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ test_expect_success '"mixed" reset is not allowed in bare' '
6363
test_must_fail git reset --mixed HEAD^
6464
'
6565

66-
test_expect_success !SANITIZE_LEAK '"soft" reset is allowed in bare' '
66+
test_expect_success '"soft" reset is allowed in bare' '
6767
git reset --soft HEAD^ &&
6868
git show --pretty=format:%s >out &&
6969
echo one >expect &&

t/t7504-commit-msg-hook.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ test_description='commit-msg hook'
55
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
66
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
77

8+
TEST_PASSES_SANITIZE_LEAK=true
89
. ./test-lib.sh
910

1011
test_expect_success 'with no hook' '

t/t9115-git-svn-dcommit-funky-renames.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55

66
test_description='git svn dcommit can commit renames of files with ugly names'
77

8-
TEST_FAILS_SANITIZE_LEAK=true
98
. ./lib-git-svn.sh
109

1110
test_expect_success 'load repository with strange names' '

t/t9146-git-svn-empty-dirs.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
test_description='git svn creates empty directories'
66

7-
TEST_FAILS_SANITIZE_LEAK=true
87
. ./lib-git-svn.sh
98

109
test_expect_success 'initialize repo' '

t/t9160-git-svn-preserve-empty-dirs.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ This test uses git to clone a Subversion repository that contains empty
99
directories, and checks that corresponding directories are created in the
1010
local Git repository with placeholder files.'
1111

12-
TEST_FAILS_SANITIZE_LEAK=true
1312
. ./lib-git-svn.sh
1413

1514
GIT_REPO=git-svn-repo

0 commit comments

Comments
 (0)