Skip to content

Commit f74bbc8

Browse files
peffgitster
authored andcommitted
revision: drop --show-all option
This was an undocumented debugging aid that does not seem to have come in handy in the past decade, judging from its lack of mentions on the mailing list. Let's drop it in the name of simplicity. This is morally a revert of 3131b71 (Add "--show-all" revision walker flag for debugging, 2008-02-09), but note that I did leave in the mapping of UNINTERESTING to "^" in get_revision_mark(). I don't think this would be possible to trigger with the current code, but it's the only sensible marker. We'll skip the usual deprecation period because this was explicitly a debugging aid that was never documented. Signed-off-by: Jeff King <[email protected]> Acked-by: Linus Torvalds <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 7fa31b6 commit f74bbc8

File tree

3 files changed

+0
-42
lines changed

3 files changed

+0
-42
lines changed

revision.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1055,14 +1055,9 @@ static int limit_list(struct rev_info *revs)
10551055
return -1;
10561056
if (obj->flags & UNINTERESTING) {
10571057
mark_parents_uninteresting(commit);
1058-
if (revs->show_all)
1059-
p = &commit_list_insert(commit, p)->next;
10601058
slop = still_interesting(list, date, slop, &interesting_cache);
10611059
if (slop)
10621060
continue;
1063-
/* If showing all, add the whole pending list to the end */
1064-
if (revs->show_all)
1065-
*p = list;
10661061
break;
10671062
}
10681063
if (revs->min_age != -1 && (commit->date > revs->min_age))
@@ -1853,8 +1848,6 @@ static int handle_revision_opt(struct rev_info *revs, int argc, const char **arg
18531848
revs->dense = 1;
18541849
} else if (!strcmp(arg, "--sparse")) {
18551850
revs->dense = 0;
1856-
} else if (!strcmp(arg, "--show-all")) {
1857-
revs->show_all = 1;
18581851
} else if (!strcmp(arg, "--in-commit-order")) {
18591852
revs->tree_blobs_in_commit_order = 1;
18601853
} else if (!strcmp(arg, "--remove-empty")) {
@@ -3061,8 +3054,6 @@ enum commit_action get_commit_action(struct rev_info *revs, struct commit *commi
30613054
return commit_ignore;
30623055
if (revs->unpacked && has_sha1_pack(commit->object.oid.hash))
30633056
return commit_ignore;
3064-
if (revs->show_all)
3065-
return commit_show;
30663057
if (commit->object.flags & UNINTERESTING)
30673058
return commit_ignore;
30683059
if (revs->min_age != -1 &&
@@ -3161,7 +3152,6 @@ enum commit_action simplify_commit(struct rev_info *revs, struct commit *commit)
31613152
enum commit_action action = get_commit_action(revs, commit);
31623153

31633154
if (action == commit_show &&
3164-
!revs->show_all &&
31653155
revs->prune && revs->dense && want_ancestry(revs)) {
31663156
/*
31673157
* --full-diff on simplified parents is no good: it

revision.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ struct rev_info {
9090
unsigned int dense:1,
9191
prune:1,
9292
no_walk:2,
93-
show_all:1,
9493
remove_empty_trees:1,
9594
simplify_history:1,
9695
topo_order:1,

t/t6015-rev-list-show-all-parents.sh

Lines changed: 0 additions & 31 deletions
This file was deleted.

0 commit comments

Comments
 (0)