ci(windows): transfer the entire worktree to the test jobs

Git's test suite is excruciatingly slow on Windows, mainly due to the
fact that it executes a lot of shell script code, and that's simply not
native to Windows.

To help with that, we established the pattern where the artifacts are
first built in one job, and then multiple test jobs run in parallel
using the artifacts built in the first job.

We take pains in transferring only the build outputs, and letting
`actions/checkout` fill in the rest of the files.

One major downside is that the test jobs might fail to check out the
intended revision (e.g. because the branch has been updated while the
build was running, as is frequently the case with the `seen` branch).

Let's just transfer the entire worktree (excluding the `vcpkg` artifacts
in the `vs-*` jobs because they are "heavy" and not needed for the test
suite), so as to prepare better for above-mentioned scenario.

Signed-off-by: Johannes Schindelin <[email protected]>

Author: dscho

.github/workflows/main.yml

@@ -88,12 +88,12 @@ jobs:
       env:
         HOME: ${{runner.workspace}}
         NO_PERL: 1
-      run: ci/make-test-artifacts.sh artifacts
-    - name: upload build artifacts
+      run: ci/run-build-and-tests.sh --skip-tests
+    - name: upload worktree with build artifacts
       uses: actions/upload-artifact@v2
       with:
         name: windows-artifacts
-        path: artifacts
+        path: .
   windows-test:
     runs-on: windows-latest
     needs: [windows-build]
@@ -102,15 +102,11 @@ jobs:
       matrix:
         nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
     steps:
-    - uses: actions/checkout@v1
-    - name: download build artifacts
+    - name: download worktree with build artifacts
       uses: actions/download-artifact@v2
       with:
         name: windows-artifacts
         path: ${{github.workspace}}
-    - name: extract build artifacts
-      shell: bash
-      run: tar xf artifacts.tar.gz
     - uses: git-for-windows/setup-git-for-windows-sdk@main
     - name: test
       shell: bash
@@ -156,19 +152,13 @@ jobs:
         -DMSGFMT_EXE=C:/git-sdk-64-minimal/mingw64/bin/msgfmt.exe -DPERL_TESTS=OFF -DPYTHON_TESTS=OFF -DCURL_NO_CURL_CMAKE=ON
     - name: MSBuild
       run: msbuild git.sln -property:Configuration=Release -property:Platform=x64 -maxCpuCount:4 -property:PlatformToolset=v142
-    - name: bundle artifact tar
-      shell: bash
-      env:
-        MSVC: 1
-        VCPKG_ROOT: ${{github.workspace}}\compat\vcbuild\vcpkg
-      run: |
-        mkdir -p artifacts &&
-        eval "$(make -n artifacts-tar INCLUDE_DLLS_IN_ARTIFACTS=YesPlease ARTIFACTS_DIRECTORY=artifacts 2>&1 | grep ^tar)"
-    - name: upload build artifacts
+    - name: upload worktree with build artifacts
       uses: actions/upload-artifact@v2
       with:
         name: vs-artifacts
-        path: artifacts
+        path: |
+          .
+          !contrib/
   vs-test:
     runs-on: windows-latest
     needs: vs-build
@@ -177,16 +167,12 @@ jobs:
       matrix:
         nr: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
     steps:
-    - uses: actions/checkout@v1
     - uses: git-for-windows/setup-git-for-windows-sdk@main
     - name: download build artifacts
       uses: actions/download-artifact@v2
       with:
         name: vs-artifacts
         path: ${{github.workspace}}
-    - name: extract build artifacts
-      shell: bash
-      run: tar xf artifacts.tar.gz
     - name: test
       shell: bash
       env:

ci/make-test-artifacts.sh

@@ -11,6 +11,9 @@ windows*) cmd //c mklink //j t\\.prove "$(cygpath -aw "$cache_dir/.prove")";;
 esac
 
 make
+check_unignored_build_artifacts
+test --skip-tests != "$*" || exit 0
+
 case "$jobname" in
 linux-gcc)
 	make test
@@ -40,6 +43,4 @@ linux-gcc-4.8)
 	;;
 esac
 
-check_unignored_build_artifacts
-
 save_good_tree