Cleanup

Author: aadrijnberg

CONTRIBUTING.md

@@ -2,11 +2,11 @@
 
 We'd love for you to contribute to our source code and to make the Forest even better than it is today! Here are the guidelines we'd like you to follow:
 
-- [Question or Problem?](#question)
-- [Issues and Bugs](#issue)
-- [Feature Requests](#feature)
-- [Submission Guidelines](#submit)
-- [Further Info](#info)
+* [Question or Problem?](#question)
+* [Issues and Bugs](#issue)
+* [Feature Requests](#feature)
+* [Submission Guidelines](#submit)
+* [Further Info](#info)
 
 ## <a name="question"></a> Got a Question or Problem?
 
@@ -24,8 +24,8 @@ If you find a bug in the source code or a mistake in the documentation, you can
 
 You can request a new feature by submitting an issue to our [Github Repository][github]. If you would like to implement a new feature then consider what kind of change it is:
 
-- **Major Changes** that you wish to contribute to the project should be discussed first on our [Slack group][slack] so that we can better coordinate our efforts, prevent duplication of work, and help you to craft the change so that it is successfully accepted into the project.
-- **Small Changes** can be crafted and submitted to the [Github Repository][github] as a Pull Request.
+* **Major Changes** that you wish to contribute to the project should be discussed first on our [Slack group][slack] so that we can better coordinate our efforts, prevent duplication of work, and help you to craft the change so that it is successfully accepted into the project.
+* **Small Changes** can be crafted and submitted to the [Github Repository][github] as a Pull Request.
 
 ## <a name="docs"></a> Want a Doc Fix?
 
@@ -41,12 +41,12 @@ Before you submit your issue search the archive, maybe your question was already
 
 If your issue appears to be a bug, and hasn't been reported, open a new issue. Help us to maximize the effort we can spend fixing issues and adding new features, by not reporting duplicate issues. Providing the following information will increase the chances of your issue being dealt with quickly:
 
-- **Overview of the Issue** - if an error is being thrown a non-minified stack trace helps
-- **Motivation for or Use Case** - explain why this is a bug for you
-- **Forest Version(s)** - is it a regression?
-- **Reproduce the Error** - try to describe how to reproduce the error
-- **Related Issues** - has a similar issue been reported before?
-- **Suggest a Fix** - if you can't fix the bug yourself, perhaps you can point to what might be
+* **Overview of the Issue** - if an error is being thrown a non-minified stack trace helps
+* **Motivation for or Use Case** - explain why this is a bug for you
+* **Forest Version(s)** - is it a regression?
+* **Reproduce the Error** - try to describe how to reproduce the error
+* **Related Issues** - has a similar issue been reported before?
+* **Suggest a Fix** - if you can't fix the bug yourself, perhaps you can point to what might be
   causing the problem (line of code or commit)
 
 **If you get help, help others. Good karma rulez!**
@@ -55,45 +55,45 @@ If your issue appears to be a bug, and hasn't been reported, open a new issue. H
 
 Before you submit your merge request consider the following guidelines:
 
-- Make your changes in a new git branch:
+* Make your changes in a new git branch:
 
-  ```shell
-  git checkout -b my-fix-branch develop
-  ```
+    ```shell
+    git checkout -b my-fix-branch develop
+    ```
 
-- Create your patch, **including appropriate test cases**.
-- Run the test suite and ensure that all tests pass.
-- Add a line in the CHANGELOG.md under Unreleased. This will be used form generating the release notes.
-- Install [pre-commit hooks](https://pre-commit.com/). The hooks runs some basic checks and update the docs. The commit will run the hooks, you can invoke the hooks manually `pre-commit run --all-files` as well.
-- Commit your changes using a descriptive commit message.
+* Create your patch, **including appropriate test cases**.
+* Run the test suite and ensure that all tests pass.
+* Add a line in the CHANGELOG.md under Unreleased. This will be used form generating the release notes.
+* Install [pre-commit hooks](https://pre-commit.com/). The hooks runs some basic checks and update the docs. The commit will run the hooks, you can invoke the hooks manually `pre-commit run --all-files` as well.
+* Commit your changes using a descriptive commit message.
 
-  ```shell
-  git commit -a
-  ```
+    ```shell
+    git commit -a
+    ```
 
   Note: the optional commit `-a` command line option will automatically "add" and "rm" edited files.
 
-- Build your changes locally to ensure all the tests pass:
-- Push your branch to Github:
+* Build your changes locally to ensure all the tests pass:
+* Push your branch to Github:
 
-  ```shell
-  git push origin my-fix-branch
-  ```
+    ```shell
+    git push origin my-fix-branch
+    ```
 
 In Github, send a pull request to original develop branch: f.e. `terraform-aws-vpc:develop`.
 If we suggest changes, then:
 
-- Make the required updates.
-- Re-run the test suite to ensure tests are still passing.
-- Commit your changes to your branch (e.g. `my-fix-branch`).
-- Push the changes to your Github repository (this will update your Pull Request).
+* Make the required updates.
+* Re-run the test suite to ensure tests are still passing.
+* Commit your changes to your branch (e.g. `my-fix-branch`).
+* Push the changes to your Github repository (this will update your Pull Request).
 
 If the PR gets too outdated we may ask you to rebase and force push to update the PR:
 
-```shell
-git rebase develop -i
-git push origin my-fix-branch -f
-```
+    ```shell
+    git rebase develop -i
+    git push origin my-fix-branch -f
+    ```
 
 _WARNING: Squashing or reverting commits and force-pushing thereafter may remove Github comments on code that were previously made by you or others in your commits. Avoid any form of rebasing unless necessary._
 
@@ -104,29 +104,29 @@ That's it! Thank you for your contribution!
 After your pull request is merged, you can safely delete your branch and pull the changes
 from the main (upstream) repository:
 
-- Delete the remote branch on Github either through the Github web UI or your local shell as follows:
+* Delete the remote branch on Github either through the Github web UI or your local shell as follows:
 
-  ```shell
-  git push origin --delete my-fix-branch
-  ```
+    ```shell
+    git push origin --delete my-fix-branch
+    ```
 
-- Check out the develop branch:
+* Check out the develop branch:
 
-  ```shell
-  git checkout develop -f
-  ```
+    ```shell
+    git checkout develop -f
+    ```
 
-- Delete the local branch:
+* Delete the local branch:
 
-  ```shell
-  git branch -D my-fix-branch
-  ```
+    ```shell
+    git branch -D my-fix-branch
+    ```
 
-- Update your develop with the latest upstream version:
+* Update your develop with the latest upstream version:
 
-  ```shell
-  git pull --ff upstream develop
-  ```
+    ```shell
+    git pull --ff upstream develop
+    ```
 
 ## <a name="info"></a> Info
 

modules/webhook/lambdas/webhook/src/webhook/handler.test.ts

@@ -1,4 +1,3 @@
-// import { mocked } from 'ts-jest/utils';
 import { handle } from './handler';
 import { mocked } from 'ts-jest/utils';
 import { Webhooks } from '@octokit/webhooks';
@@ -8,7 +7,6 @@ import workflowjob_event from '../../test/resources/github_workflowjob_event.jso
 import checkrun_event from '../../test/resources/github_check_run_event.json';
 import nock from 'nock';
 
-const mockDecrypt = jest.fn();
 jest.mock('../sqs');
 jest.mock('../ssm');