You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Roles and responsibilities of the maintainers of the project.
4
+
5
+
## Maintainers
6
+
7
+
| Name | GitHub | Affiliation |
8
+
| --------- | -------- | ----------- |
9
+
| Niek Palm |[@npalm]| Philips |
10
+
11
+
## Responsibilities
12
+
13
+
### Pull Requests
14
+
15
+
Maintainers are responsible to review and merge pull requests. Currently we have no end-to-end automation to test a pull request. Here a short guide how to review a pull request.
16
+
17
+
#### Guidelines
18
+
19
+
- Check if changes are implemented for both modules (root and multi-runner)
20
+
- Check backwards compatibility, we strive to keep the module compatible with previous versions
21
+
- Check complexity of the changes, if the changes are too complex. Think about how does impact the PR on the long term maintaining the module.
22
+
- Check all pipelines are passing, if not request the author to fix the issues
23
+
- In case any new dependency is added ensure we can trust and rely on the dependency. Make explicit comments in the PR that the dependency is safe to use.
24
+
25
+
#### Test
26
+
27
+
The following steps needs to be applied to test a PR
28
+
29
+
1. Check to which deployment scenario the PR belongs to: "single runner (default example)" or "multi runner"
30
+
2. Deploy per scenario the main branch
31
+
3. Apply the PR to the deployment. Check output for breaking changes such as destroying resources containing state.
32
+
4. Test the PR by running a workflow
33
+
34
+
### Security
35
+
36
+
Act on security issues as soon as possible. If a security issue is reported.
0 commit comments