Skip to content

Commit 9c3521c

Browse files
committed
feat: Remove support check_run (#2521)
* chore: Remove support check_run * format, lint
1 parent 505adf3 commit 9c3521c

File tree

8 files changed

+171
-131
lines changed

8 files changed

+171
-131
lines changed

README.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,14 @@ A logical question would be, why not Kubernetes? In the current approach, we sta
4747

4848
## Overview
4949

50-
The moment a GitHub action workflow requiring a `self-hosted` runner is triggered, GitHub will try to find a runner which can execute the workload. This module reacts to GitHub's [`check_run` event](https://docs.github.com/en/developers/webhooks-and-events/webhooks/webhook-events-and-payloads#check_run) or [`workflow_job` event](https://docs.github.com/en/free-pro-team@latest/developers/webhooks-and-events/webhook-events-and-payloads#workflow_job) for the triggered workflow and creates a new runner if necessary.
50+
The moment a GitHub action workflow requiring a `self-hosted` runner is triggered, GitHub will try to find a runner which can execute the workload. This module reacts to GitHub's [`workflow_job` event](https://docs.github.com/en/free-pro-team@latest/developers/webhooks-and-events/webhook-events-and-payloads#workflow_job) for the triggered workflow and creates a new runner if necessary.
5151

52-
For receiving the `check_run` or `workflow_job` event by the webhook (lambda), a webhook needs to be created in GitHub. The `workflow_job` is the preferred option, and the `check_run` option will be maintained for backward compatibility. The advantage of the `workflow_job` event is that the runner checks if the received event can run on the configured runners by matching the labels, which avoid instances being scaled up and never used. The following options are available:
52+
For receiving the `workflow_job` event by the webhook (lambda), a webhook needs to be created in GitHub. The `check_run` option is dropped from version 2.x. The following options to sent the event are supported.
5353

54-
- `workflow_job`: **(preferred option)** create a webhook on enterprise, org or app level. Select this option for ephemeral runners.
55-
- `check_run`: create a webhook on enterprise, org, repo or app level. When using the app option, the app needs to be installed to repo's are using the self-hosted runners.
56-
- a Webhook needs to be created. The webhook hook can be defined on enterprise, org, repo, or app level.
54+
- Create a GitHup app, define a webhook and subscribe the app to the `workflow_job` event.
55+
- Create a webhook on enterprise, org or repo level, define a webhook and subscribe the app to the `workflow_job` event.
5756

58-
In AWS a [API gateway](https://docs.aws.amazon.com/apigateway/index.html) endpoint is created that is able to receive the GitHub webhook events via HTTP post. The gateway triggers the webhook lambda which will verify the signature of the event. This check guarantees the event is sent by the GitHub App. The lambda only handles `workflow_job` or `check_run` events with status `queued` and matching the runner labels (only for `workflow_job`). The accepted events are posted on a SQS queue. Messages on this queue will be delayed for a configurable amount of seconds (default 30 seconds) to give the available runners time to pick up this build.
57+
In AWS a [API gateway](https://docs.aws.amazon.com/apigateway/index.html) endpoint is created that is able to receive the GitHub webhook events via HTTP post. The gateway triggers the webhook lambda which will verify the signature of the event. This check guarantees the event is sent by the GitHub App. The lambda only handles `workflow_job` events with status `queued` and matching the runner labels. The accepted events are posted on a SQS queue. Messages on this queue will be delayed for a configurable amount of seconds (default 30 seconds) to give the available runners time to pick up this build.
5958

6059
The "scale up runner" lambda listens to the SQS queue and picks up events. The lambda runs various checks to decide whether a new EC2 spot instance needs to be created. For example, the instance is not created if the build is already started by an existing runner, or the maximum number of runners is reached.
6160

modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/yarn.lock

Lines changed: 112 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
resolved "https://registry.yarnpkg.com/@babel/compat-data/-/compat-data-7.19.4.tgz#95c86de137bf0317f3a570e1b6e996b427299747"
4949
integrity sha512-CHIGpJcUQ5lU9KrPHTjBMhVwQG6CQjxfg36fGXl3qk/Gik1WwWachaXFuo0uCWJT/mStOKtcbFJCaVLihC1CMw==
5050

51-
51+
"@babel/[email protected]", "@babel/core@^7.12.3":
5252
version "7.17.8"
5353
resolved "https://registry.yarnpkg.com/@babel/core/-/core-7.17.8.tgz#3dac27c190ebc3a4381110d46c80e77efe172e1a"
5454
integrity sha512-OdQDV/7cRBtJHLSOBqqbYNkOcydOgnX59TZx4puf41fzcVtN3e/4yqY8lMQsK+5X2lJtAdmA+6OHqsj1hBJ4IQ==
@@ -69,7 +69,7 @@
6969
json5 "^2.1.2"
7070
semver "^6.3.0"
7171

72-
"@babel/core@^7.11.6", "@babel/core@^7.12.3":
72+
"@babel/core@^7.11.6":
7373
version "7.19.3"
7474
resolved "https://registry.yarnpkg.com/@babel/core/-/core-7.19.3.tgz#2519f62a51458f43b682d61583c3810e7dcee64c"
7575
integrity sha512-WneDJxdsjEvyKtXKsaBGbDeiyOjR5vYq4HcShxnIbG0qixpoHjI3MqeZM9NDvsojNCEBItQE4juOo/bU6e72gQ==
@@ -108,6 +108,15 @@
108108
"@jridgewell/gen-mapping" "^0.3.2"
109109
jsesc "^2.5.1"
110110

111+
"@babel/generator@^7.19.3", "@babel/generator@^7.19.4":
112+
version "7.19.5"
113+
resolved "https://registry.yarnpkg.com/@babel/generator/-/generator-7.19.5.tgz#da3f4b301c8086717eee9cab14da91b1fa5dcca7"
114+
integrity sha512-DxbNz9Lz4aMZ99qPpO1raTbcrI1ZeYh+9NR9qhfkQIbFtVEqotHojEBxHzmxhVONkGt6VyrqVQcgpefMy9pqcg==
115+
dependencies:
116+
"@babel/types" "^7.19.4"
117+
"@jridgewell/gen-mapping" "^0.3.2"
118+
jsesc "^2.5.1"
119+
111120
"@babel/helper-compilation-targets@^7.17.7":
112121
version "7.18.9"
113122
resolved "https://registry.yarnpkg.com/@babel/helper-compilation-targets/-/helper-compilation-targets-7.18.9.tgz#69e64f57b524cde3e5ff6cc5a9f4a387ee5563bf"
@@ -157,6 +166,14 @@
157166
"@babel/template" "^7.18.10"
158167
"@babel/types" "^7.19.0"
159168

169+
"@babel/helper-function-name@^7.19.0":
170+
version "7.19.0"
171+
resolved "https://registry.yarnpkg.com/@babel/helper-function-name/-/helper-function-name-7.19.0.tgz#941574ed5390682e872e52d3f38ce9d1bef4648c"
172+
integrity sha512-WAwHBINyrpqywkUH0nTnNgI5ina5TFn85HKS0pbPDfxFfhyR/aNQEn4hGi1P1JyT//I0t4OgXUlofzWILRvS5w==
173+
dependencies:
174+
"@babel/template" "^7.18.10"
175+
"@babel/types" "^7.19.0"
176+
160177
"@babel/helper-get-function-arity@^7.16.7":
161178
version "7.16.7"
162179
resolved "https://registry.yarnpkg.com/@babel/helper-get-function-arity/-/helper-get-function-arity-7.16.7.tgz#ea08ac753117a669f1508ba06ebcc49156387419"
@@ -495,6 +512,22 @@
495512
debug "^4.1.0"
496513
globals "^11.1.0"
497514

515+
"@babel/traverse@^7.19.0", "@babel/traverse@^7.19.3", "@babel/traverse@^7.19.4":
516+
version "7.19.4"
517+
resolved "https://registry.yarnpkg.com/@babel/traverse/-/traverse-7.19.4.tgz#f117820e18b1e59448a6c1fa9d0ff08f7ac459a8"
518+
integrity sha512-w3K1i+V5u2aJUOXBFFC5pveFLmtq1s3qcdDNC2qRI6WPBQIDaKFqXxDEqDO/h1dQ3HjsZoZMyIy6jGLq0xtw+g==
519+
dependencies:
520+
"@babel/code-frame" "^7.18.6"
521+
"@babel/generator" "^7.19.4"
522+
"@babel/helper-environment-visitor" "^7.18.9"
523+
"@babel/helper-function-name" "^7.19.0"
524+
"@babel/helper-hoist-variables" "^7.18.6"
525+
"@babel/helper-split-export-declaration" "^7.18.6"
526+
"@babel/parser" "^7.19.4"
527+
"@babel/types" "^7.19.4"
528+
debug "^4.1.0"
529+
globals "^11.1.0"
530+
498531
499532
version "7.17.0"
500533
resolved "https://registry.yarnpkg.com/@babel/types/-/types-7.17.0.tgz#a826e368bccb6b3d84acd76acad5c0d87342390b"
@@ -512,6 +545,15 @@
512545
"@babel/helper-validator-identifier" "^7.19.1"
513546
to-fast-properties "^2.0.0"
514547

548+
"@babel/types@^7.18.10", "@babel/types@^7.19.0", "@babel/types@^7.19.3", "@babel/types@^7.19.4":
549+
version "7.19.4"
550+
resolved "https://registry.yarnpkg.com/@babel/types/-/types-7.19.4.tgz#0dd5c91c573a202d600490a35b33246fed8a41c7"
551+
integrity sha512-M5LK7nAeS6+9j7hAq+b3fQs+pNfUtTGq+yFFfHnauFA8zQtLRfmuipmsKDKKLuyG+wC8ABW43A153YNawNTEtw==
552+
dependencies:
553+
"@babel/helper-string-parser" "^7.19.4"
554+
"@babel/helper-validator-identifier" "^7.19.1"
555+
to-fast-properties "^2.0.0"
556+
515557
"@bcoe/v8-coverage@^0.2.3":
516558
version "0.2.3"
517559
resolved "https://registry.yarnpkg.com/@bcoe/v8-coverage/-/v8-coverage-0.2.3.tgz#75a2e8b51cb758a7553d6804a5932d7aace75c39"
@@ -749,10 +791,22 @@
749791
slash "^3.0.0"
750792
write-file-atomic "^4.0.1"
751793

752-
"@jest/types@^29.2.0", "@jest/types@^29.2.1":
753-
version "29.2.1"
754-
resolved "https://registry.yarnpkg.com/@jest/types/-/types-29.2.1.tgz#ec9c683094d4eb754e41e2119d8bdaef01cf6da0"
755-
integrity sha512-O/QNDQODLnINEPAI0cl9U6zUIDXEWXt6IC1o2N2QENuos7hlGUIthlKyV4p6ki3TvXFX071blj8HUhgLGquPjw==
794+
"@jest/types@^29.1.2":
795+
version "29.1.2"
796+
resolved "https://registry.yarnpkg.com/@jest/types/-/types-29.1.2.tgz#7442d32b16bcd7592d9614173078b8c334ec730a"
797+
integrity sha512-DcXGtoTykQB5jiwCmVr8H4vdg2OJhQex3qPkG+ISyDO7xQXbt/4R6dowcRyPemRnkH7JoHvZuxPBdlq+9JxFCg==
798+
dependencies:
799+
"@jest/schemas" "^29.0.0"
800+
"@types/istanbul-lib-coverage" "^2.0.0"
801+
"@types/istanbul-reports" "^3.0.0"
802+
"@types/node" "*"
803+
"@types/yargs" "^17.0.8"
804+
chalk "^4.0.0"
805+
806+
"@jest/types@^29.2.0":
807+
version "29.2.0"
808+
resolved "https://registry.yarnpkg.com/@jest/types/-/types-29.2.0.tgz#c0d1ef8bc1e4f4b358e7877e34157371e7881b0b"
809+
integrity sha512-mfgpQz4Z2xGo37m6KD8xEpKelaVzvYVRijmLPePn9pxgaPEtX+SqIyPNzzoeCPXKYbB4L/wYSgXDL8o3Gop78Q==
756810
dependencies:
757811
"@jest/schemas" "^29.0.0"
758812
"@types/istanbul-lib-coverage" "^2.0.0"
@@ -1589,9 +1643,9 @@ caniuse-lite@^1.0.30001366:
15891643
integrity sha512-XDgbeOHfifWV3GEES2B8rtsrADx4Jf+juKX2SICJcaUhjYBO3bR96kvEIHa15VU6ohtOhBZuPGGYGbXMRn0NCw==
15901644

15911645
caniuse-lite@^1.0.30001400:
1592-
version "1.0.30001420"
1593-
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001420.tgz#f62f35f051e0b6d25532cf376776d41e45b47ef6"
1594-
integrity sha512-OnyeJ9ascFA9roEj72ok2Ikp7PHJTKubtEJIQ/VK3fdsS50q4KWy+Z5X0A1/GswEItKX0ctAp8n4SYDE7wTu6A==
1646+
version "1.0.30001419"
1647+
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001419.tgz#3542722d57d567c8210d5e4d0f9f17336b776457"
1648+
integrity sha512-aFO1r+g6R7TW+PNQxKzjITwLOyDhVRLjW0LcwS/HCZGUUKTGNp9+IwLC4xyDSZBygVL/mxaFR3HIV6wEKQuSzw==
15951649

15961650
chalk@^2.0.0:
15971651
version "2.4.2"
@@ -1766,6 +1820,11 @@ diff-sequences@^29.2.0:
17661820
resolved "https://registry.yarnpkg.com/diff-sequences/-/diff-sequences-29.2.0.tgz#4c55b5b40706c7b5d2c5c75999a50c56d214e8f6"
17671821
integrity sha512-413SY5JpYeSBZxmenGEmCVQ8mCgtFJF0w9PROdaS6z987XC2Pd2GOKqOITLtMftmyFZqgtCOb/QA7/Z3ZXfzIw==
17681822

1823+
diff-sequences@^29.2.0:
1824+
version "29.2.0"
1825+
resolved "https://registry.yarnpkg.com/diff-sequences/-/diff-sequences-29.2.0.tgz#4c55b5b40706c7b5d2c5c75999a50c56d214e8f6"
1826+
integrity sha512-413SY5JpYeSBZxmenGEmCVQ8mCgtFJF0w9PROdaS6z987XC2Pd2GOKqOITLtMftmyFZqgtCOb/QA7/Z3ZXfzIw==
1827+
17691828
diff@^4.0.1:
17701829
version "4.0.2"
17711830
resolved "https://registry.yarnpkg.com/diff/-/diff-4.0.2.tgz#60f3aecb89d5fae520c11aa19efc2bb982aade7d"
@@ -1798,9 +1857,9 @@ electron-to-chromium@^1.4.188:
17981857
integrity sha512-8nCXyIQY9An88NXAp+PuPy5h3/w5ZY7Iu2lag65Q0XREprcat5F8gKhoHsBUnQcFuCRnmevpR8yEBYRU3d2HDw==
17991858

18001859
electron-to-chromium@^1.4.251:
1801-
version "1.4.283"
1802-
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.283.tgz#d4f263f5df402fd799c0a06255d580dcf8aa9a8e"
1803-
integrity sha512-g6RQ9zCOV+U5QVHW9OpFR7rdk/V7xfopNXnyAamdpFgCHgZ1sjI8VuR1+zG2YG/TZk+tQ8mpNkug4P8FU0fuOA==
1860+
version "1.4.282"
1861+
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.282.tgz#02af3fd6051e97ac3388a4b11d455bc1ca49838f"
1862+
integrity sha512-Dki0WhHNh/br/Xi1vAkueU5mtIc9XLHcMKB6tNfQKk+kPG0TEUjRh5QEMAUbRp30/rYNMFD1zKKvbVzwq/4wmg==
18041863

18051864
emittery@^0.10.2:
18061865
version "0.10.2"
@@ -2042,7 +2101,7 @@ exit@^0.1.2:
20422101
resolved "https://registry.yarnpkg.com/exit/-/exit-0.1.2.tgz#0632638f8d877cc82107d30a0fff1a17cba1cd0c"
20432102
integrity sha1-BjJjj42HfMghB9MKD/8aF8uhzQw=
20442103

2045-
expect@^29.0.0, expect@^29.2.0:
2104+
expect@^29.2.0:
20462105
version "29.2.0"
20472106
resolved "https://registry.yarnpkg.com/expect/-/expect-29.2.0.tgz#b90c6df52be7abfd9f206f273fbcf8b33d8f332d"
20482107
integrity sha512-03ClF3GWwUqd9Grgkr9ZSdaCJGMRA69PQ8jT7o+Bx100VlGiAFf9/8oIm9Qve7ZVJhuJxFftqFhviZJRxxNfvg==
@@ -2700,6 +2759,16 @@ jest-diff@^29.2.0:
27002759
jest-get-type "^29.2.0"
27012760
pretty-format "^29.2.0"
27022761

2762+
jest-diff@^29.2.0:
2763+
version "29.2.0"
2764+
resolved "https://registry.yarnpkg.com/jest-diff/-/jest-diff-29.2.0.tgz#b1e11ac1a1401fc4792ef8ba406b48f1ae7d2bc5"
2765+
integrity sha512-GsH07qQL+/D/GxlnU+sSg9GL3fBOcuTlmtr3qr2pnkiODCwubNN2/7slW4m3CvxDsEus/VEOfQKRFLyXsUlnZw==
2766+
dependencies:
2767+
chalk "^4.0.0"
2768+
diff-sequences "^29.2.0"
2769+
jest-get-type "^29.2.0"
2770+
pretty-format "^29.2.0"
2771+
27032772
jest-docblock@^29.2.0:
27042773
version "29.2.0"
27052774
resolved "https://registry.yarnpkg.com/jest-docblock/-/jest-docblock-29.2.0.tgz#307203e20b637d97cee04809efc1d43afc641e82"
@@ -2730,6 +2799,11 @@ jest-environment-node@^29.2.0:
27302799
jest-mock "^29.2.0"
27312800
jest-util "^29.2.0"
27322801

2802+
jest-get-type@^27.5.1:
2803+
version "27.5.1"
2804+
resolved "https://registry.yarnpkg.com/jest-get-type/-/jest-get-type-27.5.1.tgz#3cd613c507b0f7ace013df407a1c1cd578bcb4f1"
2805+
integrity sha512-2KY95ksYSaK7DMBWQn6dQz3kqAf3BB64y2udeG+hv4KfSOb9qwcYQstTJc1KCbsix+wLZWZYN8t7nwX3GOBLRw==
2806+
27332807
jest-get-type@^29.2.0:
27342808
version "29.2.0"
27352809
resolved "https://registry.yarnpkg.com/jest-get-type/-/jest-get-type-29.2.0.tgz#726646f927ef61d583a3b3adb1ab13f3a5036408"
@@ -2762,6 +2836,16 @@ jest-leak-detector@^29.2.0:
27622836
jest-get-type "^29.2.0"
27632837
pretty-format "^29.2.0"
27642838

2839+
jest-matcher-utils@^27.0.0:
2840+
version "27.5.1"
2841+
resolved "https://registry.yarnpkg.com/jest-matcher-utils/-/jest-matcher-utils-27.5.1.tgz#9c0cdbda8245bc22d2331729d1091308b40cf8ab"
2842+
integrity sha512-z2uTx/T6LBaCoNWNFWwChLBKYxTMcGBRjAt+2SbP929/Fflb9aa5LGma654Rz8z9HLxsrUaYzxE9T/EFIL/PAw==
2843+
dependencies:
2844+
chalk "^4.0.0"
2845+
jest-diff "^29.2.0"
2846+
jest-get-type "^29.2.0"
2847+
pretty-format "^29.2.0"
2848+
27652849
jest-matcher-utils@^29.2.0:
27662850
version "29.2.0"
27672851
resolved "https://registry.yarnpkg.com/jest-matcher-utils/-/jest-matcher-utils-29.2.0.tgz#d1d73add0e0efb0e316a50f296977505dc053e02"
@@ -2962,7 +3046,7 @@ jest-worker@^29.2.0:
29623046
merge-stream "^2.0.0"
29633047
supports-color "^8.0.0"
29643048

2965-
jest@^29.2:
3049+
jest@^29.1:
29663050
version "29.2.0"
29673051
resolved "https://registry.yarnpkg.com/jest/-/jest-29.2.0.tgz#e7997bc603f31e04edbbe87dd24cf6e7c432abac"
29683052
integrity sha512-6krPemKUXCEu5Fh3j6ZVoLMjpTQVm0OCU+7f3K/9gllX8wNIE6NSCQ6s0q2RDoiKLRaQlVRHyscjSPRPqCI0Fg==
@@ -3377,6 +3461,15 @@ pretty-format@^29.0.0, pretty-format@^29.2.0:
33773461
ansi-styles "^5.0.0"
33783462
react-is "^18.0.0"
33793463

3464+
pretty-format@^29.2.0:
3465+
version "29.2.0"
3466+
resolved "https://registry.yarnpkg.com/pretty-format/-/pretty-format-29.2.0.tgz#1d4ea56fb46079b44efd9ed59c14f70f2950a61b"
3467+
integrity sha512-QCSUFdwOi924g24czhOH5eTkXxUCqlLGZBRCySlwDYHIXRJkdGyjJc9nZaqhlFBZws8dq5Dvk0lCilsmlfsPxw==
3468+
dependencies:
3469+
"@jest/schemas" "^29.0.0"
3470+
ansi-styles "^5.0.0"
3471+
react-is "^18.0.0"
3472+
33803473
progress@^2.0.0:
33813474
version "2.0.3"
33823475
resolved "https://registry.yarnpkg.com/progress/-/progress-2.0.3.tgz#7e8cf8d8f5b8f239c1bc68beb4eb78567d572ef8"
@@ -3420,6 +3513,11 @@ react-is@^18.0.0:
34203513
resolved "https://registry.yarnpkg.com/react-is/-/react-is-18.2.0.tgz#199431eeaaa2e09f86427efbb4f1473edb47609b"
34213514
integrity sha512-xWGDIW6x921xtzPkhiULtthJHoJvBbF3q26fzloPCK0hsvxtPVelvftw3zjbHWSkR2km9Z+4uxbDDK/6Zw9B8w==
34223515

3516+
react-is@^18.0.0:
3517+
version "18.2.0"
3518+
resolved "https://registry.yarnpkg.com/react-is/-/react-is-18.2.0.tgz#199431eeaaa2e09f86427efbb4f1473edb47609b"
3519+
integrity sha512-xWGDIW6x921xtzPkhiULtthJHoJvBbF3q26fzloPCK0hsvxtPVelvftw3zjbHWSkR2km9Z+4uxbDDK/6Zw9B8w==
3520+
34233521
readdirp@~3.6.0:
34243522
version "3.6.0"
34253523
resolved "https://registry.yarnpkg.com/readdirp/-/readdirp-3.6.0.tgz#74a370bd857116e245b29cc97340cd431a02a6c7"

modules/runners/lambdas/runners/src/scale-runners/scale-up.test.ts

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -227,11 +227,6 @@ describe('scaleUp with GHES', () => {
227227
expect(createRunner).toBeCalledWith(expectedRunnerParams);
228228
});
229229

230-
it('creates a runner with legacy event check_run', async () => {
231-
await scaleUpModule.scaleUp('aws:sqs', { ...TEST_DATA, eventType: 'check_run' });
232-
expect(createRunner).toBeCalledWith(expectedRunnerParams);
233-
});
234-
235230
it('creates a runner with labels in a specific group', async () => {
236231
process.env.RUNNER_EXTRA_LABELS = 'label1,label2';
237232
process.env.RUNNER_GROUP_NAME = 'TEST_GROUP';
@@ -402,14 +397,6 @@ describe('scaleUp with public GH', () => {
402397
expect(listEC2Runners).not.toBeCalled();
403398
});
404399

405-
it('does not list runners when no workflows are queued (check_run)', async () => {
406-
mockOctokit.checks.get.mockImplementation(() => ({
407-
data: { status: 'completed' },
408-
}));
409-
await scaleUpModule.scaleUp('aws:sqs', { ...TEST_DATA, eventType: 'check_run' });
410-
expect(listEC2Runners).not.toBeCalled();
411-
});
412-
413400
describe('on org level', () => {
414401
beforeEach(() => {
415402
process.env.ENABLE_ORGANIZATION_RUNNERS = 'true';
@@ -449,11 +436,6 @@ describe('scaleUp with public GH', () => {
449436
expect(createRunner).toBeCalledWith(expectedRunnerParams);
450437
});
451438

452-
it('creates a runner with legacy event check_run', async () => {
453-
await scaleUpModule.scaleUp('aws:sqs', { ...TEST_DATA, eventType: 'check_run' });
454-
expect(createRunner).toBeCalledWith(expectedRunnerParams);
455-
});
456-
457439
it('creates a runner with labels in s specific group', async () => {
458440
process.env.RUNNER_EXTRA_LABELS = 'label1,label2';
459441
process.env.RUNNER_GROUP_NAME = 'TEST_GROUP';

modules/runners/lambdas/runners/src/scale-runners/scale-up.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -105,13 +105,6 @@ async function isJobQueued(githubInstallationClient: Octokit, payload: ActionReq
105105
repo: payload.repositoryName,
106106
});
107107
isQueued = jobForWorkflowRun.data.status === 'queued';
108-
} else if (payload.eventType === 'check_run') {
109-
const checkRun = await githubInstallationClient.checks.get({
110-
check_run_id: payload.id,
111-
owner: payload.repositoryOwner,
112-
repo: payload.repositoryName,
113-
});
114-
isQueued = checkRun.data.status === 'queued';
115108
} else {
116109
throw Error(`Event ${payload.eventType} is not supported`);
117110
}

modules/runners/lambdas/runners/yarn.lock

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2386,9 +2386,9 @@ caniuse-lite@^1.0.30001366:
23862386
integrity sha512-wgfRYa9DenEomLG/SdWgQxpIyvdtH3NW8Vq+tB6AwR9e56iOIcu1im5F/wNdDf04XlKHXqIx4N8Jo0PemeBenQ==
23872387

23882388
caniuse-lite@^1.0.30001400:
2389-
version "1.0.30001420"
2390-
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001420.tgz#f62f35f051e0b6d25532cf376776d41e45b47ef6"
2391-
integrity sha512-OnyeJ9ascFA9roEj72ok2Ikp7PHJTKubtEJIQ/VK3fdsS50q4KWy+Z5X0A1/GswEItKX0ctAp8n4SYDE7wTu6A==
2389+
version "1.0.30001419"
2390+
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001419.tgz#3542722d57d567c8210d5e4d0f9f17336b776457"
2391+
integrity sha512-aFO1r+g6R7TW+PNQxKzjITwLOyDhVRLjW0LcwS/HCZGUUKTGNp9+IwLC4xyDSZBygVL/mxaFR3HIV6wEKQuSzw==
23922392

23932393
chalk@^2.0.0:
23942394
version "2.4.2"
@@ -2597,9 +2597,9 @@ electron-to-chromium@^1.4.188:
25972597
integrity sha512-uxMa/Dt7PQsLBVXwH+t6JvpHJnrsYBaxWKi/J6HE+/nBtoHENhwBoNkgkm226/Kfxeg0z1eMQLBRPPKcDH8xWA==
25982598

25992599
electron-to-chromium@^1.4.251:
2600-
version "1.4.283"
2601-
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.283.tgz#d4f263f5df402fd799c0a06255d580dcf8aa9a8e"
2602-
integrity sha512-g6RQ9zCOV+U5QVHW9OpFR7rdk/V7xfopNXnyAamdpFgCHgZ1sjI8VuR1+zG2YG/TZk+tQ8mpNkug4P8FU0fuOA==
2600+
version "1.4.282"
2601+
resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.4.282.tgz#02af3fd6051e97ac3388a4b11d455bc1ca49838f"
2602+
integrity sha512-Dki0WhHNh/br/Xi1vAkueU5mtIc9XLHcMKB6tNfQKk+kPG0TEUjRh5QEMAUbRp30/rYNMFD1zKKvbVzwq/4wmg==
26032603

26042604
emittery@^0.10.2:
26052605
version "0.10.2"

0 commit comments

Comments
 (0)