Asset Explorer context menu shows "Release Lock" when it shouldn't

[StanleyGoldman]

Context menu in asset explorer shows "Release Lock" and "Release Lock (forced)" for files that are not locked by the current user. Only "Release Lock (forced)" should appear. The LocksView has similar dropdowns and is correct in this respect.

[StanleyGoldman]

Somehow related to #851 & #852
This should've been fixed i think

[StanleyGoldman]

This is the functionality for the Project Explorer

Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/ProjectWindowInterface.cs

Lines 98 to 120 in 5ae520f

	[MenuItem(AssetsMenuReleaseLock, true, 10001)]
	private static bool ContextMenu_CanUnlock()
	{
	if (!EnsureInitialized())
	return false;
	if (!Repository.CurrentRemote.HasValue)
	return false;
	if (isBusy)
	return false;
	return Selection.objects.Any(IsObjectLocked);
	}
	[MenuItem(AssetsMenuReleaseLockForced, true, 10002)]
	private static bool ContextMenu_CanUnlockForce()
	{
	if (!EnsureInitialized())
	return false;
	if (!Repository.CurrentRemote.HasValue)
	return false;
	if (isBusy)
	return false;
	return Selection.objects.Any(IsObjectLocked);
	}

Hopefully it follows something near the same logic in the LocksView. (Initial inspection seems to indicate no)

Unity/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/LocksView.cs

Lines 446 to 452 in 5ae520f

	var menu = new GenericMenu();
	if (entry.Owner.Name == currentUsername)
	{
	menu.AddItem(unlockFileMenuContent, false, UnlockSelectedEntry);
	}
	menu.AddItem(forceUnlockFileMenuContent, false, ForceUnlockSelectedEntry);
	menu.ShowAsContext();