Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 5722b18

Browse files
author
Meaghan Lewis
authored
Merge pull request #2130 from github/donokuda/tall-orgs
Prefer a DockPanel over a Grid for forking a repo
2 parents 29c95b8 + 16b5bb8 commit 5722b18

File tree

1 file changed

+6
-14
lines changed

1 file changed

+6
-14
lines changed

src/GitHub.VisualStudio.UI/Views/Dialog/ForkRepositorySelectView.xaml

Lines changed: 6 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -23,26 +23,18 @@
2323
<sampleData:ForkRepositorySelectViewModelDesigner IsLoading="True"/>
2424
</d:DesignProperties.DataContext>
2525

26-
<Grid Margin="0 8">
27-
<Grid.RowDefinitions>
28-
<RowDefinition Height="Auto"/>
29-
<RowDefinition Height="Auto"/>
30-
<RowDefinition Height="*"/>
31-
<RowDefinition Height="Auto"/>
32-
</Grid.RowDefinitions>
33-
34-
<TextBlock Grid.Row="0" FontSize="16" Margin="8">
26+
<DockPanel Margin="0 8">
27+
<TextBlock FontSize="16" Margin="8" DockPanel.Dock="Top">
3528
Where should we fork this repository?
3629
</TextBlock>
3730

38-
<ui:GitHubProgressBar Grid.Row="1"
31+
<ui:GitHubProgressBar DockPanel.Dock="Top"
3932
Foreground="{DynamicResource GitHubAccentBrush}"
4033
IsIndeterminate="True"
4134
Style="{DynamicResource GitHubProgressBar}"
4235
Visibility="{Binding IsLoading, Converter={ui:BooleanToHiddenVisibilityConverter}}"/>
4336

4437
<ListBox Name="accountsListBox"
45-
Grid.Row="2"
4638
BorderThickness="0"
4739
ItemsSource="{Binding Accounts}"
4840
VerticalContentAlignment="Top"
@@ -76,8 +68,8 @@
7668
</ListBox.ItemTemplate>
7769
</ListBox>
7870

79-
<DockPanel Grid.Row="3"
80-
Margin="0 16 0 0"
71+
<DockPanel Margin="0 16 0 0"
72+
DockPanel.Dock="Bottom"
8173
Visibility="{Binding ExistingForks, Converter={ui:HasItemsVisibilityConverter}}">
8274
<TextBlock DockPanel.Dock="Top" Margin="8 0">
8375
<Run FontWeight="SemiBold">Can't find what you're looking for?</Run>
@@ -98,5 +90,5 @@
9890
</ItemsControl.ItemTemplate>
9991
</ItemsControl>
10092
</DockPanel>
101-
</Grid>
93+
</DockPanel>
10294
</UserControl>

0 commit comments

Comments
 (0)