renamed the shared query

Author: mbaluda

c/cert/src/rules/STR34-C/CastCharBeforeConvertingToLargerSizes.ql

@@ -14,9 +14,9 @@
 
 import cpp
 import codingstandards.c.cert
-import codingstandards.cpp.rules.castcharbeforeconvertingtolargersizes_shared.CastCharBeforeConvertingToLargerSizes_shared
+import codingstandards.cpp.rules.castcharbeforeconvertingtolargersizes.CastCharBeforeConvertingToLargerSizes
 
-class CastCharBeforeConvertingToLargerSizesQuery extends CastCharBeforeConvertingToLargerSizes_sharedSharedQuery
+class CastCharBeforeConvertingToLargerSizesQuery extends CastCharBeforeConvertingToLargerSizesSharedQuery
 {
   CastCharBeforeConvertingToLargerSizesQuery() {
     this = Strings3Package::castCharBeforeConvertingToLargerSizesQuery()

c/cert/test/rules/STR34-C/CastCharBeforeConvertingToLargerSizes.testref

@@ -1 +1 @@
-c/common/test/rules/castcharbeforeconvertingtolargersizes_shared/CastCharBeforeConvertingToLargerSizes_shared.ql
+c/common/test/rules/castcharbeforeconvertingtolargersizes/CastCharBeforeConvertingToLargerSizes.ql

c/common/test/rules/castcharbeforeconvertingtolargersizes_shared/CastCharBeforeConvertingToLargerSizes_shared.expected renamed to c/common/test/rules/castcharbeforeconvertingtolargersizes/CastCharBeforeConvertingToLargerSizes.expected

@@ -1,4 +1,4 @@
 // GENERATED FILE - DO NOT MODIFY
-import codingstandards.cpp.rules.castcharbeforeconvertingtolargersizes_shared.CastCharBeforeConvertingToLargerSizes_shared
+import codingstandards.cpp.rules.castcharbeforeconvertingtolargersizes.CastCharBeforeConvertingToLargerSizes
 
-class TestFileQuery extends CastCharBeforeConvertingToLargerSizes_sharedSharedQuery, TestQuery { }
+class TestFileQuery extends CastCharBeforeConvertingToLargerSizesSharedQuery, TestQuery { }

c/common/test/rules/castcharbeforeconvertingtolargersizes_shared/CastCharBeforeConvertingToLargerSizes_shared.expected.clang renamed to c/common/test/rules/castcharbeforeconvertingtolargersizes/CastCharBeforeConvertingToLargerSizes.expected.clang

@@ -0,0 +1,27 @@
+/**
+ * Provides a library which includes a `problems` predicate for reporting....
+ */
+
+ import cpp
+ import codingstandards.cpp.Customizations
+ import codingstandards.cpp.Exclusions
+ 
+ abstract class CastCharBeforeConvertingToLargerSizesSharedQuery extends Query { }
+ 
+ Query getQuery() { result instanceof CastCharBeforeConvertingToLargerSizesSharedQuery }
+ 
+ query predicate problems(Cast c, string message) {
+   not isExcluded(c, getQuery()) and
+   // find cases where there is a conversion happening wherein the
+   // base type is a char
+   c.getExpr().getType() instanceof CharType and
+   not c.getExpr().getType() instanceof UnsignedCharType and
+   // it's a bigger type
+   c.getType().getSize() > c.getExpr().getType().getSize() and
+   // and it's some kind of integer type
+   c.getType().getUnderlyingType() instanceof IntegralType and
+   not c.isFromTemplateInstantiation(_) and
+   message =
+     "Expression not converted to `unsigned char` before converting to a larger integer type."
+ }
+ 

c/common/test/rules/castcharbeforeconvertingtolargersizes_shared/CastCharBeforeConvertingToLargerSizes_shared.expected.gcc renamed to c/common/test/rules/castcharbeforeconvertingtolargersizes/CastCharBeforeConvertingToLargerSizes.expected.gcc

@@ -1,4 +1,4 @@
 // GENERATED FILE - DO NOT MODIFY
-import codingstandards.cpp.rules.castcharbeforeconvertingtolargersizes_shared.CastCharBeforeConvertingToLargerSizes_shared
+import codingstandards.cpp.rules.castcharbeforeconvertingtolargersizes.CastCharBeforeConvertingToLargerSizes
 
-class TestFileQuery extends CastCharBeforeConvertingToLargerSizes_sharedSharedQuery, TestQuery { }
+class TestFileQuery extends CastCharBeforeConvertingToLargerSizesSharedQuery, TestQuery { }

c/common/test/rules/castcharbeforeconvertingtolargersizes_shared/CastCharBeforeConvertingToLargerSizes_shared.expected.qcc renamed to c/common/test/rules/castcharbeforeconvertingtolargersizes/CastCharBeforeConvertingToLargerSizes.expected.qcc

@@ -12,7 +12,7 @@
           "precision": "very-high",
           "severity": "error",
           "short_name": "CastCharBeforeConvertingToLargerSizes",
-          "shared_implementation_short_name": "CastCharBeforeConvertingToLargerSizes_shared",
+          "shared_implementation_short_name": "CastCharBeforeConvertingToLargerSizes",
           "tags": [
             "correctness",
             "security"