Update DockAreaTabBar.cpp (#640)

invisibleGG · web-flow · commit 06e8451fc0fc · 2024-06-03T08:29:59.000+02:00
This fix seems to have introduced a regression when _this is deleted before the lambda slot occurred, for example deleting the DockManager (and consequently _this) immediately after the execution of updateTabs function (we encountered this problem in linux)
diff --git a/src/DockAreaTabBar.cpp b/src/DockAreaTabBar.cpp
@@ -111,7 +111,7 @@ void DockAreaTabBarPrivate::updateTabs()
 			// Sometimes the synchronous calculation of the rectangular area fails
 			// Therefore we use QTimer::singleShot here to execute the call
 			// within the event loop - see #520
-			QTimer::singleShot(0, TabWidget, [&, TabWidget]
+			QTimer::singleShot(0, _this, [&, TabWidget]
 			{
 				_this->ensureWidgetVisible(TabWidget);
 			});

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ void DockAreaTabBarPrivate::updateTabs()`
`111`	`111`	`// Sometimes the synchronous calculation of the rectangular area fails`
`112`	`112`	`// Therefore we use QTimer::singleShot here to execute the call`
`113`	`113`	`// within the event loop - see #520`
`114`		`- QTimer::singleShot(0, TabWidget, [&, TabWidget]`
	`114`	`+ QTimer::singleShot(0, _this, [&, TabWidget]`
`115`	`115`	`{`
`116`	`116`	`_this->ensureWidgetVisible(TabWidget);`
`117`	`117`	`});`