Skip to content

Commit 00d2e91

Browse files
gmessnergmessner
committed
Replaced all instances of str.length() == 0 with str.isEmpty() per lamdaV suggestion.
1 parent 2267922 commit 00d2e91

18 files changed

+59
-59
lines changed

‎src/test/java/org/gitlab4j/api/TestAccessToken.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,15 +42,15 @@ public TestAccessToken() {
4242
public static void setup() {
4343

4444
String problems = "";
45-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
45+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
4646
problems += "TEST_HOST_URL cannot be empty\n";
4747
}
4848

49-
if (TEST_ACCESS_TOKEN == null || TEST_ACCESS_TOKEN.trim().length() == 0) {
49+
if (TEST_ACCESS_TOKEN == null || TEST_ACCESS_TOKEN.trim().isEmpty()) {
5050
problems += "TEST_ACCESS_TOKEN cannot be empty\n";
5151
}
5252

53-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
53+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
5454
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
5555
}
5656

‎src/test/java/org/gitlab4j/api/TestCommitsApi.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,19 +58,19 @@ public TestCommitsApi() {
5858
public static void setup() {
5959

6060
String problems = "";
61-
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().length() == 0) {
61+
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().isEmpty()) {
6262
problems += "TEST_NAMESPACE cannot be empty\n";
6363
}
6464

65-
if (TEST_PROJECT_NAME == null || TEST_PROJECT_NAME.trim().length() == 0) {
65+
if (TEST_PROJECT_NAME == null || TEST_PROJECT_NAME.trim().isEmpty()) {
6666
problems += "TEST_PROJECT_NAME cannot be empty\n";
6767
}
6868

69-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
69+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
7070
problems += "TEST_HOST_URL cannot be empty\n";
7171
}
7272

73-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
73+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
7474
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
7575
}
7676

‎src/test/java/org/gitlab4j/api/TestDeployKeysApi.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,15 @@ public TestDeployKeysApi() {
3838
public static void setup() {
3939

4040
String problems = "";
41-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
41+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
4242
problems += "TEST_HOST_URL cannot be empty\n";
4343
}
4444

45-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
45+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
4646
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
4747
}
4848

49-
if (TEST_USERNAME == null || TEST_USERNAME.trim().length() == 0) {
49+
if (TEST_USERNAME == null || TEST_USERNAME.trim().isEmpty()) {
5050
problems += "TEST_USER_NAME cannot be empty\n";
5151
}
5252

‎src/test/java/org/gitlab4j/api/TestEventsApi.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,19 +51,19 @@ public TestEventsApi() {
5151
public static void setup() {
5252

5353
String problems = "";
54-
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().length() == 0) {
54+
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().isEmpty()) {
5555
problems += "TEST_NAMESPACE cannot be empty\n";
5656
}
5757

58-
if (TEST_PROJECT_NAME == null || TEST_PROJECT_NAME.trim().length() == 0) {
58+
if (TEST_PROJECT_NAME == null || TEST_PROJECT_NAME.trim().isEmpty()) {
5959
problems += "TEST_PROJECT_NAME cannot be empty\n";
6060
}
6161

62-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
62+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
6363
problems += "TEST_HOST_URL cannot be empty\n";
6464
}
6565

66-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
66+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
6767
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
6868
}
6969

‎src/test/java/org/gitlab4j/api/TestGitLabApi.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ public TestGitLabApi() {
4545
public static void setup() {
4646

4747
String problems = "";
48-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
48+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
4949
problems += "TEST_HOST_URL cannot be empty\n";
5050
}
5151

52-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
52+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
5353
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
5454
}
5555

‎src/test/java/org/gitlab4j/api/TestGroupApi.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,15 @@ public TestGroupApi() {
6161
public static void setup() {
6262

6363
String problems = "";
64-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
64+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
6565
problems += "TEST_HOST_URL cannot be empty\n";
6666
}
6767

68-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
68+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
6969
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
7070
}
7171

72-
if (TEST_USERNAME == null || TEST_USERNAME.trim().length() == 0) {
72+
if (TEST_USERNAME == null || TEST_USERNAME.trim().isEmpty()) {
7373
problems += "TEST_USER_NAME cannot be empty\n";
7474
}
7575

‎src/test/java/org/gitlab4j/api/TestIgnoreCertificateErrors.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ public TestIgnoreCertificateErrors() {
4040
public static void setup() {
4141

4242
String problems = "";
43-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
43+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
4444
problems += "TEST_HOST_URL cannot be empty\n";
4545
}
4646

47-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
47+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
4848
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
4949
}
5050

‎src/test/java/org/gitlab4j/api/TestIssuesApi.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,15 +85,15 @@ public TestIssuesApi() {
8585
public static void setup() {
8686

8787
String problems = "";
88-
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().length() == 0) {
88+
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().isEmpty()) {
8989
problems += "TEST_NAMESPACE cannot be empty\n";
9090
}
9191

92-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
92+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
9393
problems += "TEST_HOST_URL cannot be empty\n";
9494
}
9595

96-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
96+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
9797
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
9898
}
9999

‎src/test/java/org/gitlab4j/api/TestNamespaceApi.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,15 @@ public TestNamespaceApi() {
4646
public static void setup() {
4747

4848
String problems = "";
49-
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().length() == 0) {
49+
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().isEmpty()) {
5050
problems += "TEST_NAMESPACE cannot be empty\n";
5151
}
5252

53-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
53+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
5454
problems += "TEST_HOST_URL cannot be empty\n";
5555
}
5656

57-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
57+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
5858
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
5959
}
6060

‎src/test/java/org/gitlab4j/api/TestNotesApi.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,19 +52,19 @@ public TestNotesApi() {
5252
public static void setup() {
5353

5454
String problems = "";
55-
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().length() == 0) {
55+
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().isEmpty()) {
5656
problems += "TEST_NAMESPACE cannot be empty\n";
5757
}
5858

59-
if (TEST_PROJECT_NAME == null || TEST_PROJECT_NAME.trim().length() == 0) {
59+
if (TEST_PROJECT_NAME == null || TEST_PROJECT_NAME.trim().isEmpty()) {
6060
problems += "TEST_PROJECT_NAME cannot be empty\n";
6161
}
6262

63-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
63+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
6464
problems += "TEST_HOST_URL cannot be empty\n";
6565
}
6666

67-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
67+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
6868
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
6969
}
7070

‎src/test/java/org/gitlab4j/api/TestNotificationSettingsApi.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,19 +55,19 @@ public TestNotificationSettingsApi() {
5555
public static void setup() {
5656

5757
String problems = "";
58-
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().length() == 0) {
58+
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().isEmpty()) {
5959
problems += "TEST_NAMESPACE cannot be empty\n";
6060
}
6161

62-
if (TEST_PROJECT_NAME == null || TEST_PROJECT_NAME.trim().length() == 0) {
62+
if (TEST_PROJECT_NAME == null || TEST_PROJECT_NAME.trim().isEmpty()) {
6363
problems += "TEST_PROJECT_NAME cannot be empty\n";
6464
}
6565

66-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
66+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
6767
problems += "TEST_HOST_URL cannot be empty\n";
6868
}
6969

70-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
70+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
7171
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
7272
}
7373

‎src/test/java/org/gitlab4j/api/TestPager.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,19 +55,19 @@ public TestPager() {
5555
public static void setup() {
5656

5757
String problems = "";
58-
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().length() == 0) {
58+
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().isEmpty()) {
5959
problems += "TEST_NAMESPACE cannot be empty\n";
6060
}
6161

62-
if (TEST_PROJECT_NAME == null || TEST_PROJECT_NAME.trim().length() == 0) {
62+
if (TEST_PROJECT_NAME == null || TEST_PROJECT_NAME.trim().isEmpty()) {
6363
problems += "TEST_PROJECT_NAME cannot be empty\n";
6464
}
6565

66-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
66+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
6767
problems += "TEST_HOST_URL cannot be empty\n";
6868
}
6969

70-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
70+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
7171
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
7272
}
7373

‎src/test/java/org/gitlab4j/api/TestProjectApi.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,15 +92,15 @@ public TestProjectApi() {
9292
public static void setup() {
9393

9494
String problems = "";
95-
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().length() == 0) {
95+
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().isEmpty()) {
9696
problems += "TEST_NAMESPACE cannot be empty\n";
9797
}
9898

99-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
99+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
100100
problems += "TEST_HOST_URL cannot be empty\n";
101101
}
102102

103-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
103+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
104104
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
105105
}
106106

‎src/test/java/org/gitlab4j/api/TestProjectApiSnippets.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,15 +76,15 @@ public TestProjectApiSnippets() {
7676
public static void setup() {
7777

7878
String problems = "";
79-
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().length() == 0) {
79+
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().isEmpty()) {
8080
problems += "TEST_NAMESPACE cannot be empty\n";
8181
}
8282

83-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
83+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
8484
problems += "TEST_HOST_URL cannot be empty\n";
8585
}
8686

87-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
87+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
8888
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
8989
}
9090

‎src/test/java/org/gitlab4j/api/TestProtectedBranchesApi.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,19 +54,19 @@ public class TestProtectedBranchesApi {
5454
public static void setup() {
5555

5656
String problems = "";
57-
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().length() == 0) {
57+
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().isEmpty()) {
5858
problems += "TEST_NAMESPACE cannot be empty\n";
5959
}
6060

61-
if (TEST_PROJECT_NAME == null || TEST_PROJECT_NAME.trim().length() == 0) {
61+
if (TEST_PROJECT_NAME == null || TEST_PROJECT_NAME.trim().isEmpty()) {
6262
problems += "TEST_PROJECT_NAME cannot be empty\n";
6363
}
6464

65-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
65+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
6666
problems += "TEST_HOST_URL cannot be empty\n";
6767
}
6868

69-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
69+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
7070
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
7171
}
7272

‎src/test/java/org/gitlab4j/api/TestRepositoryApi.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,19 +68,19 @@ public TestRepositoryApi() {
6868
public static void setup() {
6969

7070
String problems = "";
71-
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().length() == 0) {
71+
if (TEST_NAMESPACE == null || TEST_NAMESPACE.trim().isEmpty()) {
7272
problems += "TEST_NAMESPACE cannot be empty\n";
7373
}
7474

75-
if (TEST_PROJECT_NAME == null || TEST_PROJECT_NAME.trim().length() == 0) {
75+
if (TEST_PROJECT_NAME == null || TEST_PROJECT_NAME.trim().isEmpty()) {
7676
problems += "TEST_PROJECT_NAME cannot be empty\n";
7777
}
7878

79-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
79+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
8080
problems += "TEST_HOST_URL cannot be empty\n";
8181
}
8282

83-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
83+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
8484
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
8585
}
8686

‎src/test/java/org/gitlab4j/api/TestSystemHooksApi.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,15 @@ public TestSystemHooksApi() {
4949
public static void setup() {
5050

5151
String problems = "";
52-
if (TEST_HOOK_URL == null || TEST_HOOK_URL.trim().length() == 0) {
52+
if (TEST_HOOK_URL == null || TEST_HOOK_URL.trim().isEmpty()) {
5353
problems += "TEST_HOOK_URL cannot be empty\n";
5454
}
5555

56-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
56+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
5757
problems += "TEST_HOST_URL cannot be empty\n";
5858
}
5959

60-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
60+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
6161
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
6262
}
6363

‎src/test/java/org/gitlab4j/api/TestUserApi.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,15 +75,15 @@ public TestUserApi() {
7575
public static void setup() {
7676

7777
String problems = "";
78-
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().length() == 0) {
78+
if (TEST_HOST_URL == null || TEST_HOST_URL.trim().isEmpty()) {
7979
problems += "TEST_HOST_URL cannot be empty\n";
8080
}
8181

82-
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().length() == 0) {
82+
if (TEST_PRIVATE_TOKEN == null || TEST_PRIVATE_TOKEN.trim().isEmpty()) {
8383
problems += "TEST_PRIVATE_TOKEN cannot be empty\n";
8484
}
8585

86-
if (TEST_USERNAME == null || TEST_USERNAME.trim().length() == 0) {
86+
if (TEST_USERNAME == null || TEST_USERNAME.trim().isEmpty()) {
8787
problems += "TEST_USER_NAME cannot be empty\n";
8888
}
8989

0 commit comments

Comments
 (0)