Skip to content

Resolved mismatch stubbings in TestGitLabApiEvents.java #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

ARMS2025
Copy link
Contributor

I analyzed the test doubles (mocks) in the test code of the project. In my analysis of the project, I observed that

In the test testSystemHookManagerHandleEvent:

  • The getHeader method for the request object:
    i) during test execution the method is actually called with argument "X-Gitlab-Token", but is not stubbed, resulting in a mismatch stubbing

In general, a mismatched stubbing occurs when a method is stubbed with specific arguments in a test but later invoked with different arguments in the code. Mockito recommends addressing this type of issue (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org.mockito/org/mockito/exceptions/misusing/PotentialStubbingProblem.html).

I propose a solution below to resolve the mismatch stubbing. Happy to modify the pull request based on your feedback.

@jmini
Copy link
Collaborator

jmini commented May 16, 2025

Thank you for this contribution. I have merged it.


I really would like to improve the integration tests and to a mocking with mock server that will serve real HTTP content. To keep this stub-content up-to-date we need to have a quick way to capture real HTTP responses from a running GitLab instance.
--> #1165

Then we would no longer use Mockito…

@jmini jmini merged commit 4b39b35 into gitlab4j:main May 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants