Skip to content

Add all parameters to get project of group api #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mdeknowis
Copy link
Contributor

List a group’s projects provides a wide API to filter for projects of a group. That would help to limit the result.

Copy link
Collaborator

@gmessner gmessner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdeknowis
Thank you for the contribution. Please see comments for requested changes

@mdeknowis
Copy link
Contributor Author

@gmessner Thanks for your feedback. I hope, I adjusted the code in a manner, that fits to your project.

Copy link
Collaborator

@gmessner gmessner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdeknowis
Thanks for making the changes. I've added a couple of additional small change requests.

@mdeknowis
Copy link
Contributor Author

@gmessner So please don't hesitate, if I still missed something, and didn't fit to our project's style and architecture.

@gmessner
Copy link
Collaborator

gmessner commented Nov 8, 2018

@mdeknowis
The changes look great. I'm going to merge this. However, I will be renaming the ProjectOfGroupFilter to GroupProjectsFilter as I prepare it for release. Could of requested this changed but wanted to get this merged so it could be used.

Thanks again for your contributions.

@gmessner gmessner merged commit b78db14 into gitlab4j:master Nov 8, 2018
@gmessner
Copy link
Collaborator

gmessner commented Nov 8, 2018

4.8.55 has been released with your enhancement.

@mdeknowis mdeknowis deleted the add-all-parameters-to-get-project-of-group-api branch November 8, 2018 07:53
@mdeknowis
Copy link
Contributor Author

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants