Skip to content

Change User representation in Webhooks #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/org/gitlab4j/api/webhook/BuildEvent.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class BuildEvent extends AbstractEvent {
private String buildFailureReason;
private Long projectId;
private String projectName;
private User user;
private EventUser user;
private BuildCommit commit;
private EventRepository repository;

Expand Down Expand Up @@ -163,11 +163,11 @@ public void setProjectName(String projectName) {
this.projectName = projectName;
}

public User getUser() {
public EventUser getUser() {
return user;
}

public void setUser(User user) {
public void setUser(EventUser user) {
this.user = user;
}

Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/gitlab4j/api/webhook/DeploymentEvent.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class DeploymentEvent extends AbstractEvent {
private String environment;
private EventProject project;
private String shortSha;
private User user;
private EventUser user;
private String userUrl;
private String commitUrl;
private String commitTitle;
Expand Down Expand Up @@ -86,11 +86,11 @@ public void setShortSha(String shortSha) {
this.shortSha = shortSha;
}

public User getUser() {
public EventUser getUser() {
return user;
}

public void setUser(User user) {
public void setUser(EventUser user) {
this.user = user;
}

Expand Down
57 changes: 57 additions & 0 deletions src/main/java/org/gitlab4j/api/webhook/EventUser.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
package org.gitlab4j.api.webhook;

import org.gitlab4j.api.utils.JacksonJson;

public class EventUser {

private Long id;
private String name;
private String username;
private String avatarUrl;
private String email;

public Long getId() {
return id;
}

public void setId(Long id) {
this.id = id;
}

public String getName() {
return name;
}

public void setName(String name) {
this.name = name;
}

public String getUsername() {
return username;
}

public void setUsername(String username) {
this.username = username;
}

public String getAvatarUrl() {
return avatarUrl;
}

public void setAvatarUrl(String avatarUrl) {
this.avatarUrl = avatarUrl;
}

public String getEmail() {
return email;
}

public void setEmail(String email) {
this.email = email;
}

@Override
public String toString() {
return (JacksonJson.toJsonString(this));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class ExternalStatusCheckEvent {

private String objectKind;
private String eventType;
private User user;
private EventUser user;
private EventProject project;
private EventRepository repository;
private ObjectAttributes objectAttributes;
Expand All @@ -36,11 +36,11 @@ public void setEventType(String eventType) {
this.eventType = eventType;
}

public User getUser() {
public EventUser getUser() {
return user;
}

public void setUser(User user) {
public void setUser(EventUser user) {
this.user = user;
}

Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/gitlab4j/api/webhook/IssueEvent.java
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class IssueEvent extends AbstractEvent {
public static final String X_GITLAB_EVENT = "Issue Hook";
public static final String OBJECT_KIND = "issue";

private User user;
private EventUser user;
private EventProject project;
private EventRepository repository;
private ObjectAttributes objectAttributes;
Expand All @@ -29,11 +29,11 @@ public void setObjectKind(String objectKind) {
throw new RuntimeException("Invalid object_kind (" + objectKind + "), must be '" + OBJECT_KIND + "'");
}

public User getUser() {
public EventUser getUser() {
return user;
}

public void setUser(User user) {
public void setUser(EventUser user) {
this.user = user;
}

Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/gitlab4j/api/webhook/JobEvent.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public class JobEvent extends AbstractEvent {
private String jobFailureReason;
private Long projectId;
private String projectName;
private User user;
private EventUser user;
private BuildCommit commit;
private EventRepository repository;

Expand Down Expand Up @@ -159,11 +159,11 @@ public void setProjectName(String projectName) {
this.projectName = projectName;
}

public User getUser() {
public EventUser getUser() {
return user;
}

public void setUser(User user) {
public void setUser(EventUser user) {
this.user = user;
}

Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/gitlab4j/api/webhook/MergeRequestEvent.java
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class MergeRequestEvent extends AbstractEvent {
public static final String X_GITLAB_EVENT = "Merge Request Hook";
public static final String OBJECT_KIND = "merge_request";

private User user;
private EventUser user;
private EventProject project;
private EventRepository repository;
private ObjectAttributes objectAttributes;
Expand All @@ -30,11 +30,11 @@ public void setObjectKind(String objectKind) {
throw new RuntimeException("Invalid object_kind (" + objectKind + "), must be '" + OBJECT_KIND + "'");
}

public User getUser() {
public EventUser getUser() {
return user;
}

public void setUser(User user) {
public void setUser(EventUser user) {
this.user = user;
}

Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/gitlab4j/api/webhook/NoteEvent.java
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class NoteEvent extends AbstractEvent {
public static final String X_GITLAB_EVENT = "Note Hook";
public static final String OBJECT_KIND = "note";

private User user;
private EventUser user;
private Long projectId;
private EventProject project;
private EventRepository repository;
Expand All @@ -35,11 +35,11 @@ public void setObjectKind(String objectKind) {
throw new RuntimeException("Invalid object_kind (" + objectKind + "), must be '" + OBJECT_KIND + "'");
}

public User getUser() {
public EventUser getUser() {
return user;
}

public void setUser(User user) {
public void setUser(EventUser user) {
this.user = user;
}

Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/gitlab4j/api/webhook/PipelineEvent.java
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class PipelineEvent extends AbstractEvent {
public static final String OBJECT_KIND = "pipeline";

private ObjectAttributes objectAttributes;
private User user;
private EventUser user;
private EventProject project;
private EventCommit commit;
private List<Job> jobs;
Expand All @@ -36,11 +36,11 @@ public void setObjectAttributes(ObjectAttributes objectAttributes) {
this.objectAttributes = objectAttributes;
}

public User getUser() {
public EventUser getUser() {
return user;
}

public void setUser(User user) {
public void setUser(EventUser user) {
this.user = user;
}

Expand Down
6 changes: 3 additions & 3 deletions src/main/java/org/gitlab4j/api/webhook/UncycloPageEvent.java
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ public class UncycloPageEvent extends AbstractEvent {
public static final String X_GITLAB_EVENT = "Uncyclo Page Hook";
public static final String OBJECT_KIND = "wiki_page";

private User user;
private EventUser user;
private EventProject project;
private Uncyclo wiki;
private ObjectAttributes objectAttributes;
Expand All @@ -22,11 +22,11 @@ public void setObjectKind(String objectKind) {
throw new RuntimeException("Invalid object_kind (" + objectKind + "), must be '" + OBJECT_KIND + "'");
}

public User getUser() {
public EventUser getUser() {
return user;
}

public void setUser(User user) {
public void setUser(EventUser user) {
this.user = user;
}

Expand Down