Skip to content

Make Pager constructor public #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Make Pager constructor public #965

merged 1 commit into from
Apr 26, 2023

Conversation

jensli
Copy link
Contributor

@jensli jensli commented Apr 25, 2023

It is often useful for clients of this library to subclass a AbstractApi, or one of its concrete subclasses, to implement custom requests towards the GitLab API.

This is hard right now, because the constructor of Pager is package private, so clients cannot access it. This is a bit weird, since Pager itself is public.

This change makes the constructor public.

This allows clients to implement custom operation more easily.
Copy link
Collaborator

@jmini jmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me the change is OK.

@jabby jabby merged commit ddd4304 into gitlab4j:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants