Skip to content

Add buildQueuedDuration to BuildEvent #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2023
Merged

Add buildQueuedDuration to BuildEvent #998

merged 2 commits into from
Jul 18, 2023

Conversation

luvarqpp
Copy link
Contributor

Fixing #780 issue.

To me, it seems valid and sending by gitlab (in my setup at least).

@jmini jmini force-pushed the feature/addQueuedDuration branch from 69e4c41 to cf6dd4b Compare July 18, 2023 08:31
@jmini jmini changed the base branch from 6.x to main July 18, 2023 08:31
@jmini
Copy link
Collaborator

jmini commented Jul 18, 2023

@luvarqpp thank you for this contribution.

I made 2 changes:

  • Your PR is now targeting the main branch, since for now we are maintaining 2 versions of the code 5.x.x and 6.x.x. I cherry-picked your commit.
  • I have added a value in the test JSON file, in order for your test to be tested in TestGitLabApiEvents

@jmini jmini force-pushed the feature/addQueuedDuration branch from cf6dd4b to 7409e5e Compare July 18, 2023 13:02
@jmini jmini merged commit 91fb052 into gitlab4j:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luvarqpp @jmini