Skip to content

Add pipeline id attribute to BuildEvent class #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

luvarqpp
Copy link
Contributor

As stated in https://docs.gitlab.com/ee/user/project/integrations/webhook_events.html#job-events, gitlab is sending numeric pipeline_id attribute directly in build kind of webhook data.

luvarqpp and others added 2 commits July 18, 2023 09:11
@jmini jmini force-pushed the feature/pipelineIdInBuildEvent branch from 442c11f to d0d91aa Compare July 18, 2023 07:17
@jmini jmini changed the base branch from 6.x to main July 18, 2023 07:17
@jmini
Copy link
Collaborator

jmini commented Jul 18, 2023

@luvarqpp thank you for this contribution.

I made 2 changes:

  • Your PR is targeting the main branch, since for now we are maintaining 2 versions of the code 5.x.x and 6.x.x
  • I have added a value in the test JSON file, in order for your test to be tested in TestGitLabApiEvents

@jmini jmini merged commit 555b4ac into gitlab4j:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants