fix(coro): stop spawning waiter threads for async futures

Author: wravery

include/graphqlservice/GraphQLService.h

@@ -342,40 +342,14 @@ class [[nodiscard]] AwaitableScalar
 		std::promise<T> _promise;
 	};
 
-	[[nodiscard]] bool await_ready() const noexcept
+	[[nodiscard("unexpected call")]] constexpr bool await_ready() const noexcept
 	{
-		return std::visit(
-			[](const auto& value) noexcept {
-				using value_type = std::decay_t<decltype(value)>;
-
-				if constexpr (std::is_same_v<value_type, T>)
-				{
-					return true;
-				}
-				else if constexpr (std::is_same_v<value_type, std::future<T>>)
-				{
-					using namespace std::literals;
-
-					return value.wait_for(0s) != std::future_status::timeout;
-				}
-				else if constexpr (std::is_same_v<value_type,
-									   std::shared_ptr<const response::Value>>)
-				{
-					return true;
-				}
-			},
-			_value);
+		return true;
 	}
 
 	void await_suspend(coro::coroutine_handle<> h) const
 	{
-		std::thread(
-			[this](coro::coroutine_handle<> h) noexcept {
-				std::get<std::future<T>>(_value).wait();
-				h.resume();
-			},
-			std::move(h))
-			.detach();
+		h.resume();
 	}
 
 	[[nodiscard]] T await_resume()
@@ -695,39 +669,18 @@ class [[nodiscard]] AwaitableObject
 		std::promise<T> _promise;
 	};
 
-	[[nodiscard]] bool await_ready() const noexcept
+	[[nodiscard("unexpected call")]] constexpr bool await_ready() const noexcept
 	{
-		return std::visit(
-			[](const auto& value) noexcept {
-				using value_type = std::decay_t<decltype(value)>;
-
-				if constexpr (std::is_same_v<value_type, T>)
-				{
-					return true;
-				}
-				else if constexpr (std::is_same_v<value_type, std::future<T>>)
-				{
-					using namespace std::literals;
-
-					return value.wait_for(0s) != std::future_status::timeout;
-				}
-			},
-			_value);
+		return true;
 	}
 
 	void await_suspend(coro::coroutine_handle<> h) const
 	{
+<<<<<<< HEAD
 		std::thread(
 			[this](coro::coroutine_handle<> h) noexcept {
 				std::get<std::future<T>>(_value).wait();
-				h.resume();
-			},
-			std::move(h))
-			.detach();
-	}
-
 	[[nodiscard]] T await_resume()
-	{
 		return std::visit(
 			[](auto&& value) -> T {
 				using value_type = std::decay_t<decltype(value)>;