[prometheus] Remove references to db_write (#17041)

Author: geropl

components/ws-manager-bridge/src/prometheus-metrics-exporter.ts

@@ -67,16 +67,12 @@ export class PrometheusMetricsExporter {
         this.workspaceInstanceUpdateStartedTotal = new prom.Counter({
             name: "gitpod_ws_manager_bridge_workspace_instance_update_started_total",
             help: "Total number of workspace instance updates that started processing",
-            // we track db_write because we need to be able to distinguish between outcomes which did affect the system negatively - failed to write,
-            // and outcomes by read-only replicas.
             labelNames: ["workspace_cluster", "workspace_instance_type"],
         });
 
         this.workspaceInstanceUpdateCompletedSeconds = new prom.Histogram({
             name: "gitpod_ws_manager_bridge_workspace_instance_update_completed_seconds",
             help: "Histogram of completed workspace instance updates, by outcome",
-            // we track db_write because we need to be able to distinguish between outcomes which did affect the system negatively - failed to write,
-            // and outcomes by read-only replicas.
             labelNames: ["workspace_cluster", "workspace_instance_type", "outcome"],
             buckets: prom.exponentialBuckets(0.05, 2, 8),
         });

operations/observability/mixins/meta/dashboards/components/ws-manager-bridge.json

@@ -238,7 +238,7 @@
             "uid": "${datasource}"
           },
           "editorMode": "code",
-          "expr": "sum(increase(gitpod_ws_manager_bridge_workspace_instance_update_started_total{db_write=\"true\", cluster=~\"$cluster\", pod=~\"$pod\"}[10m])) - sum(increase(gitpod_ws_manager_bridge_workspace_instance_update_completed_seconds_count{db_write=\"true\", cluster=~\"$cluster\", pod=~\"$pod\"}[10m]))",
+          "expr": "sum(increase(gitpod_ws_manager_bridge_workspace_instance_update_started_total{cluster=~\"$cluster\", pod=~\"$pod\"}[10m])) - sum(increase(gitpod_ws_manager_bridge_workspace_instance_update_completed_seconds_count{cluster=~\"$cluster\", pod=~\"$pod\"}[10m]))",
           "legendFormat": "# of events received - # of events completed",
           "range": true,
           "refId": "A"
@@ -331,7 +331,7 @@
             "uid": "${datasource}"
           },
           "editorMode": "code",
-          "expr": "sum(increase(gitpod_ws_manager_bridge_workspace_instance_update_completed_seconds_count{outcome=\"success\", db_write=\"true\"}[1m])) OR 0",
+          "expr": "sum(increase(gitpod_ws_manager_bridge_workspace_instance_update_completed_seconds_count{outcome=\"success\"}[1m])) OR 0",
           "interval": "",
           "legendFormat": "success",
           "range": true,
@@ -343,7 +343,7 @@
             "uid": "${datasource}"
           },
           "editorMode": "code",
-          "expr": "sum(increase(gitpod_ws_manager_bridge_workspace_instance_update_completed_seconds_count{outcome=\"error\", db_write=\"true\"}[1m])) OR 0",
+          "expr": "sum(increase(gitpod_ws_manager_bridge_workspace_instance_update_completed_seconds_count{outcome=\"error\"}[1m])) OR 0",
           "hide": false,
           "interval": "",
           "legendFormat": "error",
@@ -1597,7 +1597,7 @@
                 "uid": "${datasource}"
               },
               "editorMode": "code",
-              "expr": "histogram_quantile(0.5, sum(rate(gitpod_ws_manager_bridge_workspace_instance_update_completed_seconds_bucket{db_write=\"true\", cluster=~\"$cluster\", pod=~\"$pod\"}[5m])) by (le))",
+              "expr": "histogram_quantile(0.5, sum(rate(gitpod_ws_manager_bridge_workspace_instance_update_completed_seconds_bucket{cluster=~\"$cluster\", pod=~\"$pod\"}[5m])) by (le))",
               "legendFormat": "50th",
               "range": true,
               "refId": "A"
@@ -1608,7 +1608,7 @@
                 "uid": "${datasource}"
               },
               "editorMode": "code",
-              "expr": "histogram_quantile(0.90, sum(rate(gitpod_ws_manager_bridge_workspace_instance_update_completed_seconds_bucket{db_write=\"true\", cluster=~\"$cluster\", pod=~\"$pod\"}[5m])) by (le))",
+              "expr": "histogram_quantile(0.90, sum(rate(gitpod_ws_manager_bridge_workspace_instance_update_completed_seconds_bucket{cluster=~\"$cluster\", pod=~\"$pod\"}[5m])) by (le))",
               "hide": false,
               "legendFormat": "90th",
               "range": true,
@@ -1620,7 +1620,7 @@
                 "uid": "${datasource}"
               },
               "editorMode": "code",
-              "expr": "histogram_quantile(0.99, sum(rate(gitpod_ws_manager_bridge_workspace_instance_update_completed_seconds_bucket{db_write=\"true\", cluster=~\"$cluster\", pod=~\"$pod\"}[5m])) by (le))",
+              "expr": "histogram_quantile(0.99, sum(rate(gitpod_ws_manager_bridge_workspace_instance_update_completed_seconds_bucket{cluster=~\"$cluster\", pod=~\"$pod\"}[5m])) by (le))",
               "hide": false,
               "legendFormat": "99th",
               "range": true,