extract Project.isPrebuildsEnabled

Author: AlexTugarev

components/dashboard/src/projects/ProjectSettings.tsx

@@ -123,11 +123,7 @@ export default function ProjectSettingsView() {
     // TODO: Render a generic error screen for when an entity isn't found
     if (!project) return null;
 
-    const enablePrebuilds =
-        !!project.settings?.enablePrebuilds ||
-        // TODO(at): out of scope for now, but once we've migrated the settings of existings projects
-        // we can remove the implicit enablement here
-        !project.settings;
+    const enablePrebuilds = Project.isPrebuildsEnabled(project);
 
     return (
         <ProjectSettingsPage project={project}>

components/gitpod-protocol/src/teams-projects-protocol.ts

@@ -55,6 +55,25 @@ export namespace Project {
         return p.name + "-" + p.id;
     }
 
+    /**
+     * If *no settings* are present on pre-existing projects, this defaults to `true` (enabled) for
+     * backwards compatibility. This allows to do any explicit migration of data or adjustment of
+     * the default behavior at a later point in time.
+     *
+     * Otherwise this returns the value of the `enablePrebuilds` settings persisted in the given
+     * project.
+     */
+    export function isPrebuildsEnabled(project: Project): boolean {
+        // Defaulting to `true` for backwards compatibility. Ignoring non-boolean for `enablePrebuilds`
+        // for evaluation here allows to do any explicit migration of data or adjustment of the default
+        // behavior at a later point in time.
+        if (typeof project.settings?.enablePrebuilds === "undefined") {
+            return true;
+        }
+
+        return project.settings.enablePrebuilds;
+    }
+
     export interface Overview {
         branches: BranchDetails[];
         isConsideredInactive?: boolean;

components/server/src/prebuilds/prebuild-manager.ts

@@ -353,14 +353,7 @@ export class PrebuildManager {
             return false;
         }
 
-        // Defaulting to `true` for backwards compatibility. Ignoring non-boolean for `enablePrebuilds`
-        // for evaluation here allows to do any explicit migration of data or adjustment of the default
-        // behavior at a later point in time.
-        if (typeof project.settings?.enablePrebuilds === "undefined") {
-            return true;
-        }
-
-        return project.settings.enablePrebuilds;
+        return Project.isPrebuildsEnabled(project);
     }
 
     protected shouldPrebuildIncrementally(cloneUrl: string, project: Project): boolean {