[installer] Move namespace constant to common pkg

Author: Furisto

install/installer/pkg/common/constants.go

@@ -59,6 +59,7 @@ const (
 	DBCaFileName                    = "ca.crt"
 	DBCaBasePath                    = "/db-ssl"
 	DBCaPath                        = DBCaBasePath + "/" + DBCaFileName
+	WorkspaceSecretsNamespace       = "workspace-secrets"
 
 	AnnotationConfigChecksum = "gitpod.io/checksum_config"
 

install/installer/pkg/components/ws-manager-mk2/configmap.go

@@ -185,7 +185,7 @@ func configmap(ctx *common.RenderContext) ([]runtime.Object, error) {
 	wsmcfg := config.ServiceConfiguration{
 		Manager: config.Configuration{
 			Namespace:        ctx.Namespace,
-			SecretsNamespace: WorkspaceSecretsNamespace,
+			SecretsNamespace: common.WorkspaceSecretsNamespace,
 			SchedulerName:    schedulerName,
 			SeccompProfile:   fmt.Sprintf("workspace_default_%s.json", ctx.VersionManifest.Version),
 			WorkspaceDaemon: config.WorkspaceDaemonConfiguration{

install/installer/pkg/components/ws-manager-mk2/constants.go

@@ -18,5 +18,4 @@ const (
 	VolumeWorkspaceTemplate    = "workspace-template"
 	WorkspaceTemplatePath      = "/workspace-templates"
 	WorkspaceTemplateConfigMap = "workspace-templates"
-	WorkspaceSecretsNamespace  = "workspace-secrets"
 )

install/installer/pkg/components/ws-manager-mk2/namespace.go

@@ -16,7 +16,7 @@ func namespace(ctx *common.RenderContext) ([]runtime.Object, error) {
 		&v1.Namespace{
 			TypeMeta: common.TypeMetaNamespace,
 			ObjectMeta: metav1.ObjectMeta{
-				Name: WorkspaceSecretsNamespace,
+				Name: common.WorkspaceSecretsNamespace,
 			},
 		},
 	}, nil

install/installer/pkg/components/ws-manager-mk2/role.go

@@ -145,7 +145,7 @@ func role(ctx *common.RenderContext) ([]runtime.Object, error) {
 			TypeMeta: common.TypeMetaRole,
 			ObjectMeta: metav1.ObjectMeta{
 				Name:      Component,
-				Namespace: WorkspaceSecretsNamespace,
+				Namespace: common.WorkspaceSecretsNamespace,
 				Labels:    labels,
 			},
 			Rules: controllerRules,

install/installer/pkg/components/ws-manager-mk2/rolebinding.go

@@ -62,7 +62,7 @@ func rolebinding(ctx *common.RenderContext) ([]runtime.Object, error) {
 			TypeMeta: common.TypeMetaRoleBinding,
 			ObjectMeta: metav1.ObjectMeta{
 				Name:      Component,
-				Namespace: WorkspaceSecretsNamespace,
+				Namespace: common.WorkspaceSecretsNamespace,
 				Labels:    labels,
 			},
 			RoleRef: rbacv1.RoleRef{