[server] Disable inference of extensions

Author: svenefftinge

components/server/src/config/config-inferrer.spec.ts

@@ -11,6 +11,7 @@ import { WorkspaceConfig } from "@gitpod/gitpod-protocol";
 
 function context(files: {[path:string]:string}): Context {
     return {
+        excludeVsCodeConfig: false,
         config: {},
         exists: async (path: string) => path.toString() in files,
         read: async (path: string) => files[path.toString()],

components/server/src/config/config-inferrer.ts

@@ -8,6 +8,7 @@ import { WorkspaceConfig } from "@gitpod/gitpod-protocol";
 
 export interface Context {
     config: WorkspaceConfig;
+    excludeVsCodeConfig: boolean;
     exists(path: string): Promise<boolean>;
     read(path: string): Promise<string | undefined>;
 }
@@ -93,6 +94,9 @@ export class ConfigInferrer {
     }
 
     protected addExtension(ctx: Context, extensionName: string) {
+        if (ctx.excludeVsCodeConfig) {
+            return;
+        }
         if (!ctx.config.vscode || !ctx.config.vscode.extensions) {
             ctx.config.vscode = {
                 extensions: []

components/server/src/config/configuration-service.ts

@@ -38,6 +38,8 @@ export class ConfigurationService {
         this.requestedPaths.forEach(path => !(path in cache) && readFile(path));
         const configInferrer = new ConfigInferrer();
         const config: WorkspaceConfig = await configInferrer.getConfig({
+            // TODO(se) pass down information about currently used IDE. Defaulting to disabling vscode extensions for now, to not bother non VS Code users.
+            excludeVsCodeConfig: true,
             config: {},
             read: readFile,
             exists: async (path: string) => !!(await readFile(path)),