Skip to content

Commit 1049676

Browse files
committed
[ws-daemon] Do not init on running phase
This is not a bug, just confusing for the reader. A workspace that is ready must have been initialized because a workspace is running when the readiness probe succeeds. The readiness probe succeeds when supervisor detects that the content has been initialized.
1 parent ce48eea commit 1049676

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

components/ws-daemon/pkg/controller/workspace_controller.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,7 @@ func (wsc *WorkspaceController) Reconcile(ctx context.Context, req ctrl.Request)
122122
glog.WithField("workspaceID", workspace.Name).WithField("phase", workspace.Status.Phase).Debug("Reconcile workspace")
123123

124124
if workspace.Status.Phase == workspacev1.WorkspacePhaseCreating ||
125-
workspace.Status.Phase == workspacev1.WorkspacePhaseInitializing ||
126-
workspace.Status.Phase == workspacev1.WorkspacePhaseRunning {
125+
workspace.Status.Phase == workspacev1.WorkspacePhaseInitializing {
127126

128127
result, err = wsc.handleWorkspaceInit(ctx, &workspace, req)
129128
return result, err

0 commit comments

Comments
 (0)