Skip to content

Commit 146113c

Browse files
committed
remove ws-man-bridge messagebus
1 parent 91f7e8c commit 146113c

File tree

6 files changed

+0
-106
lines changed

6 files changed

+0
-106
lines changed

components/ws-manager-bridge/src/bridge.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
*/
66

77
import { inject, injectable } from "inversify";
8-
import { MessageBusIntegration } from "./messagebus-integration";
98
import {
109
Disposable,
1110
Queue,
@@ -52,7 +51,6 @@ export type WorkspaceClusterInfo = Pick<WorkspaceCluster, "name" | "url">;
5251
export class WorkspaceManagerBridge implements Disposable {
5352
constructor(
5453
@inject(TracedWorkspaceDB) private readonly workspaceDB: DBWithTracing<WorkspaceDB>,
55-
@inject(MessageBusIntegration) private readonly messagebus: MessageBusIntegration,
5654
@inject(Metrics) private readonly metrics: Metrics,
5755
@inject(Configuration) private readonly config: Configuration,
5856
@inject(IAnalyticsWriter) private readonly analytics: IAnalyticsWriter,
@@ -363,7 +361,6 @@ export class WorkspaceManagerBridge implements Disposable {
363361
if (!!lifecycleHandler) {
364362
await lifecycleHandler();
365363
}
366-
await this.messagebus.notifyOnInstanceUpdate(ctx, userId, instance);
367364
await this.publisher.publishInstanceUpdate({
368365
ownerID: userId,
369366
instanceID: instance.id,

components/ws-manager-bridge/src/container-module.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@
77
require("reflect-metadata");
88

99
import { ContainerModule } from "inversify";
10-
import { MessageBusHelper, MessageBusHelperImpl } from "@gitpod/gitpod-messagebus/lib";
11-
import { MessagebusConfiguration } from "@gitpod/gitpod-messagebus/lib/config";
12-
import { MessageBusIntegration } from "./messagebus-integration";
1310
import { Configuration } from "./config";
1411
import * as fs from "fs";
1512
import { WorkspaceManagerBridgeFactory, WorkspaceManagerBridge } from "./bridge";
@@ -41,10 +38,6 @@ import { RedisClient } from "./redis/client";
4138
import { RedisPublisher } from "./redis/publisher";
4239

4340
export const containerModule = new ContainerModule((bind) => {
44-
bind(MessagebusConfiguration).toSelf().inSingletonScope();
45-
bind(MessageBusHelper).to(MessageBusHelperImpl).inSingletonScope();
46-
bind(MessageBusIntegration).toSelf().inSingletonScope();
47-
4841
bind(BridgeController).toSelf().inSingletonScope();
4942

5043
bind(PrometheusClientCallMetrics).toSelf().inSingletonScope();

components/ws-manager-bridge/src/main.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import * as express from "express";
99
import * as prometheusClient from "prom-client";
1010
import { log, LogrusLogLevel } from "@gitpod/gitpod-protocol/lib/util/logging";
1111
import { DebugApp } from "@gitpod/gitpod-protocol/lib/util/debug-app";
12-
import { MessageBusIntegration } from "./messagebus-integration";
1312
import { TypeORM } from "@gitpod/gitpod-db/lib/typeorm/typeorm";
1413
import { TracingManager } from "@gitpod/gitpod-protocol/lib/util/tracing";
1514
import { ClusterServiceServer } from "./cluster-service-server";
@@ -23,9 +22,6 @@ export const start = async (container: Container) => {
2322
const db = container.get(TypeORM);
2423
await db.connect();
2524

26-
const msgbus = container.get(MessageBusIntegration);
27-
await msgbus.connect();
28-
2925
const tracingManager = container.get(TracingManager);
3026
tracingManager.setup("ws-manager-bridge");
3127

components/ws-manager-bridge/src/messagebus-integration.ts

Lines changed: 0 additions & 81 deletions
This file was deleted.

components/ws-manager-bridge/src/prebuild-updater.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import { log, LogContext } from "@gitpod/gitpod-protocol/lib/util/logging";
1212
import { PrebuildStateMapper } from "./prebuild-state-mapper";
1313
import { DBWithTracing, TracedWorkspaceDB } from "@gitpod/gitpod-db/lib/traced-db";
1414
import { WorkspaceDB } from "@gitpod/gitpod-db/lib/workspace-db";
15-
import { MessageBusIntegration } from "./messagebus-integration";
1615
import { Metrics } from "./metrics";
1716
import { filterStatus } from "./bridge";
1817
import { RedisPublisher } from "./redis/publisher";
@@ -22,7 +21,6 @@ export class PrebuildUpdater {
2221
constructor(
2322
@inject(PrebuildStateMapper) private readonly prebuildStateMapper: PrebuildStateMapper,
2423
@inject(TracedWorkspaceDB) private readonly workspaceDB: DBWithTracing<WorkspaceDB>,
25-
@inject(MessageBusIntegration) private readonly messagebus: MessageBusIntegration,
2624
@inject(Metrics) private readonly prometheusExporter: Metrics,
2725
@inject(RedisPublisher) private readonly publisher: RedisPublisher,
2826
) {}
@@ -85,10 +83,6 @@ export class PrebuildUpdater {
8583

8684
// notify updates
8785
// headless update
88-
await this.messagebus.notifyHeadlessUpdate({ span }, userId, workspaceId, {
89-
type: update.type,
90-
workspaceID: workspaceId,
91-
});
9286
if (!HeadlessWorkspaceEventType.isRunning(update.type)) {
9387
await this.publisher.publishHeadlessUpdate({
9488
type: update.type,
@@ -99,7 +93,6 @@ export class PrebuildUpdater {
9993
// prebuild info
10094
const info = (await this.workspaceDB.trace({ span }).findPrebuildInfos([updatedPrebuild.id]))[0];
10195
if (info) {
102-
await this.messagebus.notifyOnPrebuildUpdate({ info, status: updatedPrebuild.state });
10396
await this.publisher.publishPrebuildUpdate({
10497
projectID: prebuild.projectId || "",
10598
prebuildID: updatedPrebuild.id,
@@ -129,7 +122,6 @@ export class PrebuildUpdater {
129122
// notify about prebuild updated
130123
const info = (await this.workspaceDB.trace({ span }).findPrebuildInfos([prebuild.id]))[0];
131124
if (info) {
132-
await this.messagebus.notifyOnPrebuildUpdate({ info, status: prebuild.state });
133125
await this.publisher.publishPrebuildUpdate({
134126
projectID: prebuild.projectId || "",
135127
prebuildID: prebuild.id,

components/ws-manager-bridge/src/workspace-instance-controller.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ import { Metrics } from "./metrics";
1414
import { WorkspaceDB } from "@gitpod/gitpod-db/lib/workspace-db";
1515
import { DBWithTracing, TracedUserDB, TracedWorkspaceDB } from "@gitpod/gitpod-db/lib/traced-db";
1616
import { UserDB } from "@gitpod/gitpod-db/lib/user-db";
17-
import { MessageBusIntegration } from "./messagebus-integration";
1817
import { IAnalyticsWriter } from "@gitpod/gitpod-protocol/lib/analytics";
1918
import { ClientProvider } from "./wsman-subscriber";
2019
import { repeat } from "@gitpod/gitpod-protocol/lib/util/repeat";
@@ -53,7 +52,6 @@ export class WorkspaceInstanceControllerImpl implements WorkspaceInstanceControl
5352
@inject(Metrics) private readonly prometheusExporter: Metrics,
5453
@inject(TracedWorkspaceDB) private readonly workspaceDB: DBWithTracing<WorkspaceDB>,
5554
@inject(TracedUserDB) private readonly userDB: DBWithTracing<UserDB>,
56-
@inject(MessageBusIntegration) private readonly messagebus: MessageBusIntegration,
5755
@inject(PrebuildUpdater) private readonly prebuildUpdater: PrebuildUpdater,
5856
@inject(IAnalyticsWriter) private readonly analytics: IAnalyticsWriter,
5957
@inject(RedisPublisher) private readonly publisher: RedisPublisher,
@@ -273,7 +271,6 @@ export class WorkspaceInstanceControllerImpl implements WorkspaceInstanceControl
273271
// important: call this after the DB update
274272
await this.onStopped(ctx, info.workspace.ownerId, info.latestInstance);
275273

276-
await this.messagebus.notifyOnInstanceUpdate(ctx, info.workspace.ownerId, info.latestInstance);
277274
await this.publisher.publishInstanceUpdate({
278275
ownerID: info.workspace.ownerId,
279276
instanceID: info.latestInstance.id,

0 commit comments

Comments
 (0)