Remove requirement of editor

Author: mustard-mh

components/dashboard/src/service/json-rpc-workspace-client.ts

@@ -138,9 +138,6 @@ export class JsonRpcWorkspaceClient implements PromiseClient<typeof WorkspaceSer
         if (!request.metadata || !request.metadata.organizationId || !uuidValidate(request.metadata.organizationId)) {
             throw new ApplicationError(ErrorCodes.BAD_REQUEST, "organizationId is required");
         }
-        if (!request.source.value.editor?.name) {
-            throw new ApplicationError(ErrorCodes.BAD_REQUEST, "editor is required");
-        }
         if (!request.source.value.url) {
             throw new ApplicationError(ErrorCodes.BAD_REQUEST, "source is required");
         }
@@ -152,8 +149,10 @@ export class JsonRpcWorkspaceClient implements PromiseClient<typeof WorkspaceSer
             workspaceClass: request.source.value.workspaceClass,
             projectId: request.metadata.configurationId,
             ideSettings: {
-                defaultIde: request.source.value.editor.name,
-                useLatestVersion: request.source.value.editor.version === "latest",
+                defaultIde: request.source.value.editor?.name,
+                useLatestVersion: request.source.value.editor?.version
+                    ? request.source.value.editor?.version === "latest"
+                    : undefined,
             },
         });
         const workspace = await this.getWorkspace({ workspaceId: response.createdWorkspaceId });

components/server/src/api/workspace-service-api.ts

@@ -124,9 +124,6 @@ export class WorkspaceServiceAPI implements ServiceImpl<typeof WorkspaceServiceI
         if (!req.source.value || !req.source.value.url) {
             throw new ApplicationError(ErrorCodes.BAD_REQUEST, "source is required");
         }
-        if (!req.source.value.editor?.name) {
-            throw new ApplicationError(ErrorCodes.BAD_REQUEST, "editor is required");
-        }
         const contextUrl = req.source.value;
         const user = await this.userService.findUserById(ctxUserId(), ctxUserId());
         const { context, project } = await this.contextService.parseContext(user, contextUrl.url, {
@@ -149,8 +146,10 @@ export class WorkspaceServiceAPI implements ServiceImpl<typeof WorkspaceServiceI
             forceDefaultImage: req.forceDefaultConfig,
             workspaceClass: contextUrl.workspaceClass,
             ideSettings: {
-                defaultIde: req.source.value.editor.name,
-                useLatestVersion: req.source.value.editor.version === "latest",
+                defaultIde: req.source.value.editor?.name,
+                useLatestVersion: req.source.value.editor?.version
+                    ? req.source.value.editor?.version === "latest"
+                    : undefined,
             },
             clientRegionCode: ctxClientRegion(),
         });