[db] add migration to alter pat table allow null expirationTime

Author: mustard-mh

components/gitpod-db/src/typeorm/entity/db-personal-access-token.ts

@@ -53,7 +53,7 @@ export class DBPersonalAccessToken {
     scopes: string[];
 
     @Column("datetime")
-    expirationTime: Date;
+    expirationTime: Date | null;
 
     @Column("datetime")
     createdAt: Date;

components/gitpod-db/src/typeorm/migration/1705393804800-PersonalAccessTokenAllowNullExpireDateonPAT.ts

@@ -0,0 +1,21 @@
+/**
+ * Copyright (c) 2024 Gitpod GmbH. All rights reserved.
+ * Licensed under the GNU Affero General Public License (AGPL).
+ * See License.AGPL.txt in the project root for license information.
+ */
+
+import { MigrationInterface, QueryRunner } from "typeorm";
+
+const table = "d_b_personal_access_token";
+
+export class PersonalAccessTokenAllowNullExpireDateonPAT1705393804800 implements MigrationInterface {
+    public async up(queryRunner: QueryRunner): Promise<void> {
+        await queryRunner.query(`ALTER TABLE ${table} MODIFY expirationTime expirationTime timestamp(6) NULL`);
+    }
+
+    public async down(queryRunner: QueryRunner): Promise<void> {
+        await queryRunner.query(
+            `ALTER TABLE ${table} CHANGE expirationTime expirationTime timestamp(6) NOT NULL DEFAULT CURRENT_TIMESTAMP(6)`,
+        );
+    }
+}

components/gitpod-db/src/typeorm/personal-access-token-db-impl.ts

@@ -29,7 +29,7 @@ export class PersonalAccessTokenDBImpl implements PersonalAccessTokenDB {
         const pat = await repo
             .createQueryBuilder("pat")
             .where(`pat.hash = :hash`, { hash })
-            .andWhere(`pat.expirationTime > :expirationTime`, { expirationTime })
+            .andWhere(`pat.expirationTime > :expirationTime OR pat.expirationTime IS NULL`, { expirationTime })
             .andWhere(`pat.deleted = false`)
             .getOne();