Cleanup

aledbf · aledbf · commit 2429e4469a34 · 2023-08-17T07:45:36.000Z
diff --git a/components/ws-manager-mk2/controllers/workspace_controller.go b/components/ws-manager-mk2/controllers/workspace_controller.go
@@ -500,8 +500,8 @@ func (r *WorkspaceReconciler) SetupWithManager(mgr ctrl.Manager) error {
 		return []string{owner.Name}
 	}
 	err := mgr.GetFieldIndexer().IndexField(context.Background(), &corev1.Pod{}, wsOwnerKey, idx)
-	if err != nil && err.Error() == "informer has already started" {
-		return nil
+	if err != nil {
+		return err
 	}
 
 	return ctrl.NewControllerManagedBy(mgr).

Original file line number	Diff line number	Diff line change
`@@ -500,8 +500,8 @@ func (r *WorkspaceReconciler) SetupWithManager(mgr ctrl.Manager) error {`
`500`	`500`	`return []string{owner.Name}`
`501`	`501`	`}`
`502`	`502`	`err := mgr.GetFieldIndexer().IndexField(context.Background(), &corev1.Pod{}, wsOwnerKey, idx)`
`503`		`- if err != nil && err.Error() == "informer has already started" {`
`504`		`- return nil`
	`503`	`+ if err != nil {`
	`504`	`+ return err`
`505`	`505`	`}`
`506`	`506`
`507`	`507`	`return ctrl.NewControllerManagedBy(mgr).`