[werft] Set more strict pre-commit rules

Author: aledbf

.pre-commit-config.yaml

@@ -1,13 +1,18 @@
 repos:
 - repo: https://github.com/pre-commit/pre-commit-hooks
-  rev: v4.0.0
+  rev: v4.0.1
   hooks:
     #- id: check-yaml
     #  args: [--allow-multiple-documents]
     # - id: end-of-file-fixer
     - id: trailing-whitespace
     - id: check-symlinks
     - id: mixed-line-ending
+    - id: check-case-conflict
+    - id: check-executables-have-shebangs
+    - id: check-shebang-scripts-are-executable
+    - id: check-merge-conflict
+
 
 # keep fork in sync!
 - repo: https://github.com/gitpod-io/pre-commit-hooks
@@ -17,7 +22,8 @@ repos:
       exclude: |
         (?x)^(
           .*example-layer.tar.gz|
-          .*\.(png|svg|ico|gpg)
+          .*\.(png|svg|ico|gpg)|
+          dev/version-manifest/version-manifest
         )$
     - id: script-must-have-extension
     - id: shellcheck

.werft/build.ts

@@ -50,7 +50,7 @@ export async function build(context, version) {
     werft.phase('validate-changes', 'validating changes');
 
     try {
-        exec(`pre-commit run --from-ref origin/HEAD --to-ref HEAD`);
+        exec(`pre-commit run --all-files --show-diff-on-failure`);
         werft.result("validate changes", "github-check-changes", "conclusion success");
         werft.done('validate-changes');
     } catch (err) {

components/ide/code/bin/code

@@ -6,11 +6,11 @@ if [ "$USER_ID" -ne 33333 ]; then
     exit 1
 fi
 
-if [ -z "$(which git)" ]; then
+if [ -z "$(command -v git)" ]; then
     echo "git not installed!"
 fi
 
-if [ -z "$(which bash)" ]; then
+if [ -z "$(command -v bash)" ]; then
     echo "bash not installed!"
 fi