[server] FIx missing User.fullName attribute for SSO users – EXP-365 (#18445)

* [server] FIx missing User.fullName attribute for SSO users

Git config prefers `User.fullName` for `git config user.name`, see https://github.com/gitpod-io/gitpod/blob/24f7b609bf79b247d72d1841282639726bcd5891/components/server/src/workspace/workspace-starter.ts#L550

This PR should re-add this values.

Users would have to re-login to get this updated.

* fixup test

Author: AlexTugarev

components/server/src/iam/iam-oidc-create-session-payload.ts

@@ -71,6 +71,9 @@ export interface OIDCCreateSessionPayload {
         Expiry: string; // "2023-01-10T12:00:00Z",
         IssuedAt: string; // "2023-01-01T12:00:00Z",
     };
+    /**
+     * https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims
+     */
     claims: {
         aud: string;
         email: string;
@@ -80,10 +83,16 @@ export interface OIDCCreateSessionPayload {
         hd?: string; // accepted domain, e.g. "gitpod.io"
         iss: string; // "https://accounts.google.com"
         locale: string; // e.g. "de"
+        /**
+         * End-User's full name in displayable form including all name parts, possibly including titles and suffixes, ordered according to the End-User's locale and preferences.
+         */
         name: string;
         picture: string; // URL of avatar
+        /**
+         * Subject - Identifier for the End-User at the Issuer.
+         */
         sub: string; // "1234567890"
     };
-    organizationId: string; // TODO(gpl) Remove once we implemented either SKIM, or a proper UserService
+    organizationId: string;
     oidcClientConfigId: string;
 }

components/server/src/iam/iam-session-app.spec.ts

@@ -42,6 +42,9 @@ class TestIamSessionApp {
         createUser: (params) => {
             return { id: "id-new-user" } as any;
         },
+        updateUser: (userId, update) => {
+            return {} as any;
+        },
     };
     protected userAuthenticationMock: Partial<UserAuthentication> = {
         findUserForLogin: async (params) => {

components/server/src/iam/iam-session-app.ts

@@ -128,6 +128,10 @@ export class IamSessionApp {
                 primaryEmail: recent.primaryEmail,
                 lastSigninTime: new Date().toISOString(),
             });
+            await this.userService.updateUser(user.id, {
+                id: user.id,
+                fullName: payload.claims.name,
+            });
         }
     }
 
@@ -141,6 +145,7 @@ export class IamSessionApp {
                     organizationId,
                     identity: { ...this.mapOIDCProfileToIdentity(payload), lastSigninTime: new Date().toISOString() },
                     userUpdate: (user) => {
+                        user.fullName = claims.name;
                         user.name = claims.name;
                         user.avatarUrl = claims.picture;
                     },