fix express unhandled endpoints

Siddhant-K-code · Siddhant-K-code · commit 2b160773ae58 · 2023-10-25T16:18:31.000Z
diff --git a/components/server/src/express-util.ts b/components/server/src/express-util.ts
@@ -73,7 +73,10 @@ export function unhandledToError(req: express.Request, res: express.Response, ne
     if (isAnsweredRequest(req, res)) {
         return next();
     }
-    return next(new Error("unhandled request: " + req.method + " " + req.originalUrl));
+    // Instead of throwing an error, send a user-friendly response for unknown routes
+    console.error("unhandled request: " + req.method + " " + req.originalUrl);
+    res.status(404).send("Page not found");
+    // return next(new Error("unhandled request: " + req.method + " " + req.originalUrl));
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,10 @@ export function unhandledToError(req: express.Request, res: express.Response, ne`
`73`	`73`	`if (isAnsweredRequest(req, res)) {`
`74`	`74`	`return next();`
`75`	`75`	`}`
`76`		`- return next(new Error("unhandled request: " + req.method + " " + req.originalUrl));`
	`76`	`+ // Instead of throwing an error, send a user-friendly response for unknown routes`
	`77`	`+ console.error("unhandled request: " + req.method + " " + req.originalUrl);`
	`78`	`+ res.status(404).send("Page not found");`
	`79`	`+ // return next(new Error("unhandled request: " + req.method + " " + req.originalUrl));`
`77`	`80`	`}`
`78`	`81`
`79`	`82`	`/**`