Skip to content

Commit 2cd5ec4

Browse files
committed
[server] fix metric registration
don't override default registry, which breaks other metrics.
1 parent b439372 commit 2cd5ec4

File tree

1 file changed

+9
-2
lines changed

1 file changed

+9
-2
lines changed

components/server/src/monitoring-endpoints.ts

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,19 @@ import { registerServerMetrics } from "./prometheus-metrics";
1313
@injectable()
1414
export class MonitoringEndpointsApp {
1515
public create(): express.Application {
16-
let registry = prometheusClient.register;
16+
const registry = prometheusClient.register;
1717

1818
prometheusClient.collectDefaultMetrics({ register: registry });
1919
registerDBMetrics(registry);
2020
registerServerMetrics(registry);
21-
registry = prometheusClient.Registry.merge([registry, redisMetricsRegistry()]);
21+
22+
// Append redis metrics to default registry
23+
redisMetricsRegistry()
24+
.getMetricsAsArray()
25+
.then((metrics) => {
26+
metrics.forEach((metric) => registry.registerMetric(metric as any));
27+
})
28+
.catch(console.error);
2229

2330
const monApp = express();
2431
monApp.get("/metrics", async (req, res) => {

0 commit comments

Comments
 (0)