fix non-constant format string in call to fmt Format method

Author: iQQBot

components/local-app/pkg/selfupdate/selfupdate.go

@@ -136,7 +136,7 @@ func DownloadManifest(ctx context.Context, baseURL string) (res *Manifest, err e
 	defer resp.Body.Close()
 
 	if resp.StatusCode != http.StatusOK {
-		return nil, fmt.Errorf(resp.Status)
+		return nil, fmt.Errorf("%s", resp.Status)
 	}
 
 	var mf Manifest

components/public-api-server/pkg/proxy/errors.go

@@ -30,41 +30,41 @@ func categorizeRPCError(err error) *connect.Error {
 	if rpcErr := new(jsonrpc2.Error); errors.As(err, &rpcErr) {
 		switch rpcErr.Code {
 		case 400:
-			return connect.NewError(connect.CodeInvalidArgument, fmt.Errorf(rpcErr.Message))
+			return connect.NewError(connect.CodeInvalidArgument, fmt.Errorf("%s", rpcErr.Message))
 		// components/gitpod-protocol/src/messaging/error.ts
 		case 401:
-			return connect.NewError(connect.CodeUnauthenticated, fmt.Errorf(rpcErr.Message))
+			return connect.NewError(connect.CodeUnauthenticated, fmt.Errorf("%s", rpcErr.Message))
 		// components/gitpod-protocol/src/messaging/error.ts
 		case 403:
-			return connect.NewError(connect.CodePermissionDenied, fmt.Errorf(rpcErr.Message))
+			return connect.NewError(connect.CodePermissionDenied, fmt.Errorf("%s", rpcErr.Message))
 		// components/gitpod-protocol/src/messaging/error.ts
 		case 404:
-			return connect.NewError(connect.CodeNotFound, fmt.Errorf(rpcErr.Message))
+			return connect.NewError(connect.CodeNotFound, fmt.Errorf("%s", rpcErr.Message))
 		// components/gitpod-protocol/src/messaging/error.ts
 		case 409:
-			return connect.NewError(connect.CodeAlreadyExists, fmt.Errorf(rpcErr.Message))
+			return connect.NewError(connect.CodeAlreadyExists, fmt.Errorf("%s", rpcErr.Message))
 		case 412:
-			return connect.NewError(connect.CodeFailedPrecondition, fmt.Errorf(rpcErr.Message))
+			return connect.NewError(connect.CodeFailedPrecondition, fmt.Errorf("%s", rpcErr.Message))
 		case 429:
-			return connect.NewError(connect.CodeResourceExhausted, fmt.Errorf(rpcErr.Message))
+			return connect.NewError(connect.CodeResourceExhausted, fmt.Errorf("%s", rpcErr.Message))
 		case 470:
-			return connect.NewError(connect.CodePermissionDenied, fmt.Errorf(rpcErr.Message))
+			return connect.NewError(connect.CodePermissionDenied, fmt.Errorf("%s", rpcErr.Message))
 		case -32603:
-			return connect.NewError(connect.CodeInternal, fmt.Errorf(rpcErr.Message))
+			return connect.NewError(connect.CodeInternal, fmt.Errorf("%s", rpcErr.Message))
 		}
 		// components/gitpod-protocol/src/messaging/error.ts - user errors
 		if rpcErr.Code >= 400 && rpcErr.Code < 500 {
-			return connect.NewError(connect.CodeInvalidArgument, fmt.Errorf(rpcErr.Message))
+			return connect.NewError(connect.CodeInvalidArgument, fmt.Errorf("%s", rpcErr.Message))
 		}
-		return connect.NewError(connect.CodeInternal, fmt.Errorf(rpcErr.Message))
+		return connect.NewError(connect.CodeInternal, fmt.Errorf("%s", rpcErr.Message))
 	}
 
 	if errors.Is(err, context.Canceled) {
-		return connect.NewError(connect.CodeDeadlineExceeded, fmt.Errorf("Request timed out"))
+		return connect.NewError(connect.CodeDeadlineExceeded, fmt.Errorf("%s", "Request timed out"))
 	}
 
 	if handshakeErr := new(protocol.ErrBadHandshake); errors.As(err, &handshakeErr) {
-		return connect.NewError(connect.CodeUnauthenticated, fmt.Errorf("Failed to establish caller identity"))
+		return connect.NewError(connect.CodeUnauthenticated, fmt.Errorf("%s", "Failed to establish caller identity"))
 	}
 
 	return connect.NewError(connect.CodeInternal, err)

components/supervisor/cmd/init.go

@@ -92,7 +92,7 @@ var initCmd = &cobra.Command{
 				if ignoreUnexpectedExitCode.Load() {
 					return
 				}
-				log.WithError(fmt.Errorf(logs)).Fatal("supervisor run error with unexpected exit code")
+				log.WithError(fmt.Errorf("%s", logs)).Fatal("supervisor run error with unexpected exit code")
 			}
 		}
 		go func() {

components/ws-daemon/cmd/content-initializer/main.go

@@ -26,7 +26,7 @@ func main() {
 	err := content.RunInitializerChild(statsFd)
 	if err != nil {
 		errfd := os.NewFile(content.RUN_INITIALIZER_CHILD_ERROUT_FD, "errout")
-		_, _ = fmt.Fprintf(errfd, err.Error())
+		_, _ = fmt.Fprintf(errfd, "%s", err.Error())
 
 		os.Exit(content.FAIL_CONTENT_INITIALIZER_EXIT_CODE)
 	}

components/ws-daemon/pkg/controller/housekeeping.go

@@ -70,7 +70,7 @@ func (h *Housekeeping) doHousekeeping(ctx context.Context) (errs []error) {
 
 		var err error
 		if len(msgs) > 0 {
-			err = fmt.Errorf(strings.Join(msgs, ". "))
+			err = fmt.Errorf("%s", strings.Join(msgs, ". "))
 		}
 		tracing.FinishSpan(span, &err)
 	}()

components/ws-manager-mk2/controllers/workspace_controller.go

@@ -527,7 +527,7 @@ func (r *WorkspaceReconciler) deleteWorkspaceSecrets(ctx context.Context, ws *wo
 	}
 
 	if len(errs) != 0 {
-		return fmt.Errorf(strings.Join(errs, ":"))
+		return fmt.Errorf("%s", strings.Join(errs, ":"))
 	}
 
 	return nil

components/ws-manager-mk2/service/imagespec.go

@@ -32,7 +32,7 @@ func (is *WorkspaceImageSpecProvider) GetImageSpec(ctx context.Context, req *reg
 		return nil, status.Errorf(codes.NotFound, "not found")
 	}
 	if err != nil {
-		return nil, status.Errorf(codes.Internal, err.Error())
+		return nil, status.Errorf(codes.Internal, "%s", err.Error())
 	}
 
 	return &regapi.GetImageSpecResponse{

components/ws-manager-mk2/service/manager.go

@@ -195,7 +195,7 @@ func (wsm *WorkspaceManagerServer) StartWorkspace(ctx context.Context, req *wsma
 	storage, err := class.Container.Limits.StorageQuantity()
 	if err != nil {
 		msg := fmt.Sprintf("workspace class %s has invalid storage quantity: %v", class.Name, err)
-		return nil, status.Errorf(codes.InvalidArgument, msg)
+		return nil, status.Errorf(codes.InvalidArgument, "%s", msg)
 	}
 
 	annotations := make(map[string]string)
@@ -690,7 +690,7 @@ func (wsm *WorkspaceManagerServer) TakeSnapshot(ctx context.Context, req *wsmana
 		}
 
 		if sso.Status.Error != "" {
-			return true, fmt.Errorf(sso.Status.Error)
+			return true, fmt.Errorf("%s", sso.Status.Error)
 		}
 
 		if sso.Status.URL != "" {

components/ws-proxy/pkg/sshproxy/server.go

@@ -600,7 +600,7 @@ func workspaceSSHUsername(ctx context.Context, workspaceIP string, workspacekitP
 	}
 
 	if resp.StatusCode != http.StatusOK {
-		return "", fmt.Errorf(fmt.Sprintf("unexpected status: %v (%v)", string(result), resp.StatusCode))
+		return "", fmt.Errorf("unexpected status: %v (%v)", string(result), resp.StatusCode)
 	}
 
 	return string(result), nil

install/installer/cmd/mirror_repo.go

@@ -16,7 +16,7 @@ var mirrorRepoCmd = &cobra.Command{
 	Use:   "repo",
 	Short: "Get original image repo for this installer",
 	RunE: func(cmd *cobra.Command, args []string) error {
-		fmt.Printf(config.GitpodContainerRegistry)
+		fmt.Print(config.GitpodContainerRegistry)
 		return nil
 	},
 }

install/installer/cmd/validate_cluster.go

@@ -84,7 +84,7 @@ var validateClusterCmd = &cobra.Command{
 			os.Exit(1)
 		}
 
-		fmt.Printf(out)
+		fmt.Print(out)
 		return nil
 	},
 }