Skip to content

Commit 3337d3d

Browse files
selfcontainedroboquat
authored andcommitted
remove new from filenames and add tooltip to branch name
1 parent 80dc959 commit 3337d3d

File tree

6 files changed

+13
-9
lines changed

6 files changed

+13
-9
lines changed

components/dashboard/src/admin/WorkspaceDetail.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import dayjs from "dayjs";
1010
import { useEffect, useState } from "react";
1111
import { Link } from "react-router-dom";
1212
import { getGitpodService } from "../service/service";
13-
import { getProjectPath } from "../workspaces/WorkspaceEntryNew";
13+
import { getProjectPath } from "../workspaces/WorkspaceEntry";
1414
import { WorkspaceStatusIndicator } from "../workspaces/WorkspaceStatusIndicator";
1515
import { getAdminLinks } from "./gcp-info";
1616
import Property from "./Property";

components/dashboard/src/admin/WorkspacesSearch.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import { useLocation } from "react-router";
2121
import { Link } from "react-router-dom";
2222
import Pagination from "../Pagination/Pagination";
2323
import { getGitpodService } from "../service/service";
24-
import { getProjectPath } from "../workspaces/WorkspaceEntryNew";
24+
import { getProjectPath } from "../workspaces/WorkspaceEntry";
2525
import WorkspaceDetail from "./WorkspaceDetail";
2626
import { AdminPageHeader } from "./AdminPageHeader";
2727
import Alert from "../components/Alert";

components/dashboard/src/app/AppRoutes.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ import { WebsocketClients } from "./WebsocketClients";
4646
import { OrgRequiredRoute } from "./OrgRequiredRoute";
4747

4848
const Setup = React.lazy(() => import(/* webpackPrefetch: true */ "../Setup"));
49-
const WorkspacesNew = React.lazy(() => import(/* webpackPrefetch: true */ "../workspaces/WorkspacesNew"));
49+
const Workspaces = React.lazy(() => import(/* webpackPrefetch: true */ "../workspaces/Workspaces"));
5050
const Account = React.lazy(() => import(/* webpackPrefetch: true */ "../user-settings/Account"));
5151
const Notifications = React.lazy(() => import(/* webpackPrefetch: true */ "../user-settings/Notifications"));
5252
const Billing = React.lazy(() => import(/* webpackPrefetch: true */ "../user-settings/Billing"));
@@ -170,7 +170,7 @@ export const AppRoutes: FunctionComponent<AppRoutesProps> = ({ user, teams }) =>
170170
<Route path={projectsPathNew} exact component={NewProject} />
171171
<Route path="/open" exact component={Open} />
172172
<Route path="/setup" exact component={Setup} />
173-
<Route path={workspacesPathMain} exact component={WorkspacesNew} />
173+
<Route path={workspacesPathMain} exact component={Workspaces} />
174174
<Route path={settingsPathAccount} exact component={Account} />
175175
<Route path={usagePathMain} exact component={Usage} />
176176
<Route path={settingsPathIntegrations} exact component={Integrations} />

components/dashboard/src/components/Tooltip.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,10 @@ function Tooltip(props: TooltipProps) {
4747
}, [showTooltipTimeout]);
4848

4949
return (
50-
<div onMouseLeave={handleMouseLeave} onMouseEnter={handleMouseEnter} className="relative">
51-
<div ref={setTriggerEl}>{props.children}</div>
50+
<>
51+
<span onMouseLeave={handleMouseLeave} onMouseEnter={handleMouseEnter} ref={setTriggerEl}>
52+
{props.children}
53+
</span>
5254
{expanded ? (
5355
<Portal>
5456
<div
@@ -64,7 +66,7 @@ function Tooltip(props: TooltipProps) {
6466
</div>
6567
</Portal>
6668
) : null}
67-
</div>
69+
</>
6870
);
6971
}
7072

components/dashboard/src/workspaces/WorkspaceEntryNew.tsx renamed to components/dashboard/src/workspaces/WorkspaceEntry.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,9 @@ export const WorkspaceEntry: FunctionComponent<Props> = ({ info }) => {
7474
</a>
7575
</ItemField>
7676
<ItemField className="w-2/12 flex flex-col my-auto">
77-
<div className="text-gray-500 dark:text-gray-400 overflow-ellipsis truncate">{currentBranch}</div>
77+
<div className="text-gray-500 dark:text-gray-400 overflow-ellipsis truncate">
78+
<Tooltip content={currentBranch}>{currentBranch}</Tooltip>
79+
</div>
7880
<div className="mr-auto">
7981
<PendingChangesDropdown workspaceInstance={info.latestInstance} />
8082
</div>

components/dashboard/src/workspaces/WorkspacesNew.tsx renamed to components/dashboard/src/workspaces/Workspaces.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
import { FunctionComponent, useCallback, useMemo, useState } from "react";
88
import Header from "../components/Header";
9-
import { WorkspaceEntry } from "./WorkspaceEntryNew";
9+
import { WorkspaceEntry } from "./WorkspaceEntry";
1010
import { ItemsList } from "../components/ItemsList";
1111
import { useCurrentUser } from "../user-context";
1212
import { User, WorkspaceInfo } from "@gitpod/gitpod-protocol";

0 commit comments

Comments
 (0)