[installer] Fix slowserver replicas (to 1) (#16531)

Author: geropl

install/installer/pkg/components/slowserver/deployment.go

@@ -381,7 +381,7 @@ func deployment(ctx *common.RenderContext) ([]runtime.Object, error) {
 			},
 			Spec: appsv1.DeploymentSpec{
 				Selector: &metav1.LabelSelector{MatchLabels: common.DefaultLabels(Component)},
-				Replicas: common.Replicas(ctx, common.ServerComponent),
+				Replicas: common.Replicas(ctx, Component),
 				Strategy: common.DeploymentStrategy,
 				Template: corev1.PodTemplateSpec{
 					ObjectMeta: metav1.ObjectMeta{

install/installer/pkg/components/slowserver/render_test.go

@@ -9,15 +9,13 @@ import (
 
 	"github.com/stretchr/testify/require"
 	appsv1 "k8s.io/api/apps/v1"
-	"k8s.io/apimachinery/pkg/api/resource"
 	"k8s.io/utils/pointer"
 
 	"github.com/gitpod-io/gitpod/installer/pkg/common"
 	"github.com/gitpod-io/gitpod/installer/pkg/components/toxiproxy"
 	config "github.com/gitpod-io/gitpod/installer/pkg/config/v1"
 	"github.com/gitpod-io/gitpod/installer/pkg/config/v1/experimental"
 	"github.com/gitpod-io/gitpod/installer/pkg/config/versions"
-	corev1 "k8s.io/api/core/v1"
 	v1 "k8s.io/api/core/v1"
 )
 
@@ -79,53 +77,6 @@ func TestServerDeployment_DbWaiterUsesToxiproxyDbHost(t *testing.T) {
 	}
 }
 
-func TestSlowServerDeployment_UsesServerReplicaCountAndResources(t *testing.T) {
-	resources := map[string]*v1.ResourceRequirements{
-		common.ServerComponent: {
-			Limits: corev1.ResourceList{
-				"cpu":    resource.MustParse("300m"),
-				"memory": resource.MustParse("300Mi"),
-			},
-			Requests: corev1.ResourceList{
-				"cpu":    resource.MustParse("200m"),
-				"memory": resource.MustParse("200Mi"),
-			},
-		},
-	}
-
-	podConfig := map[string]*config.PodConfig{
-		common.ServerComponent: {
-			Replicas:  pointer.Int32(5),
-			Resources: resources,
-		},
-	}
-
-	slowDbHost := toxiproxy.Component
-	ctx := renderContext(t, podConfig, slowDbHost)
-
-	objects, err := deployment(ctx)
-	require.NoError(t, err)
-
-	require.Len(t, objects, 1, "must render only one object")
-
-	deployment := objects[0].(*appsv1.Deployment)
-
-	require.NotNil(t, deployment.Spec.Replicas, "replica count must be specified")
-	require.Equal(t, int32(5), *deployment.Spec.Replicas, "unexpected number of replicas")
-
-	for _, c := range deployment.Spec.Template.Spec.Containers {
-		if c.Name == Component {
-			expectedResources := *resources[common.ServerComponent]
-			actualResources := c.Resources
-
-			require.Equal(t, expectedResources.Limits["cpu"], actualResources.Limits["cpu"], "cpu limit not set correctly")
-			require.Equal(t, expectedResources.Limits["memory"], actualResources.Limits["memory"], "memory limit not set correctly")
-			require.Equal(t, expectedResources.Requests["cpu"], actualResources.Requests["cpu"], "cpu request not set correctly")
-			require.Equal(t, expectedResources.Requests["memory"], actualResources.Requests["memory"], "memory request not set correctly")
-		}
-	}
-}
-
 func TestServerDeployment_MountsGithubAppSecret(t *testing.T) {
 	ctx := renderContext(t, nil, "")